Skip to content

[release-branch.go1.26] pipeline: exclude stage 0 toolchain from Component Governance - #2496

Merged
George Adams (gdams) merged 2 commits into
microsoft/release-branch.go1.26from
dev/gadams/backport-cg-stage0-go1.26
Sep 4, 2026
Merged

[release-branch.go1.26] pipeline: exclude stage 0 toolchain from Component Governance#2496
George Adams (gdams) merged 2 commits into
microsoft/release-branch.go1.26from
dev/gadams/backport-cg-stage0-go1.26

Conversation

@gdams

@gdams George Adams (gdams) commented Sep 4, 2026

Copy link
Copy Markdown
Member

Backport of #2494.

Summary

  • install the temporary Stage 0 Go bootstrap toolchain under eng/artifacts/_goStage0, matching Go 1.27 behavior
  • exclude that non-shipping directory from Component Governance scans
  • avoid attributing bootstrap-toolchain findings such as CVE-2026-42508 to this repository

Validation

  • pwsh eng/run.ps1 pipelineymlgen
    • installed Stage 0 at eng/artifacts/_goStage0/go1.25.0-1
    • used that installation to regenerate the pipeline YAML
  • git diff --check
  • verified the installed Stage 0 binary is ignored by eng/.gitignore

Copilot AI lite review requested due to automatic review settings September 4, 2026 08:44
@gdams
George Adams (gdams) requested a review from a team as a code owner September 4, 2026 08:44
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 1 pipeline(s).
There may be pipelines that require an authorized user to comment /azp run to run.

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟡 Changes recommended

The ignored directory path appears inconsistent with where the Stage 0 toolchain is installed in this repo’s build scripts, so the change likely won’t achieve the intended suppression.

Once you've addressed the issues Copilot identified, you can request another Copilot review.

Review tier: Lite
Findings: 1 Medium severity

New issues introduced by this change (1)
Severity Finding
Medium severity eng/​pipeline/​rolling-internal-pipeline.ymlignoreDirectories points at $(Build.SourcesDirectory)/eng/artifacts/_goStage0, but the repo’s…
What changed in this PR

This PR backports a pipeline change to prevent Component Governance from attributing vulnerabilities found in the temporary Stage 0 (bootstrap) Go toolchain (e.g., CVE-2026-42508) to this repository’s code.

Changes:

  • Adds a Component Governance configuration to ignore a Stage 0 toolchain directory during scanning.
File Description
eng/​pipeline/​rolling-internal-pipeline.yml Configures Component Governance to ignore a directory intended to contain the non-shipping Stage 0 bootstrap toolchain.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

Comment thread eng/pipeline/rolling-internal-pipeline.yml

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The Stage 0 install location and the Component Governance ignore rule are now aligned and consistent with existing pipeline path conventions.

Review tier: Lite
Findings: None

Issues resolved since last review (1)
Severity Finding
Medium severity eng/​pipeline/​rolling-internal-pipeline.ymlignoreDirectories points at $(Build.SourcesDirectory)/eng/artifacts/_goStage0, but the repo’s… View resolved comment

@gdams
George Adams (gdams) merged commit 8e4ba73 into microsoft/release-branch.go1.26 Sep 4, 2026
43 checks passed
@gdams
George Adams (gdams) deleted the dev/gadams/backport-cg-stage0-go1.26 branch September 4, 2026 10:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants