[release-branch.go1.27] internal/fakecgo: use libthr.so.3 instead of libpthread.so on FreeBSD - #2434
Merged
Conversation
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
Backports an upstream purego-based internal/fakecgo fix into the Microsoft Go vendor patch set so that FreeBSD fakecgo pthread symbol imports resolve against libthr.so.3 (instead of libpthread.so), aligning with FreeBSD’s threading library layout.
Changes:
- Bumps
github.com/microsoft/go-crypto-opensslto a newer pseudo-version that contains the FreeBSD fakecgo change. - Updates the vendored
fakecgo.lockto the corresponding upstream commit hash (d476432…). - Switches FreeBSD
//go:cgo_import_dynamicpthread imports fromlibpthread.sotolibthr.so.3.
Patches are happy!
Show a summary per file
| File | Description |
|---|---|
| patches/0001-Vendor-external-dependencies.patch | Updates the vendor patch to pull in the purego FreeBSD fakecgo change and bumps related module metadata/lockfile entries. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Low
karianna
approved these changes
Jul 28, 2026
gdams
enabled auto-merge (squash)
July 28, 2026 10:56
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Pulls down ebitengine/purego@d476432