Skip to content

Upgrade nodejs to version 24.18.1 to fix CVE-2026-56846, CVE-2026-56848, CVE-2026-58043, CVE-2026-56850, CVE-2026-58040, CVE-2026-58041, CVE-2026-58042, CVE-2026-58045, CVE-2026-56847, CVE-2026-58039, CVE-2026-58044 - #18259

Open
v-aaditya wants to merge 1 commit into
microsoft:3.0-devfrom
Kanishk-Bansal:topic-upgrade/nodejs24/3.0/24.18.1

Conversation

@v-aaditya

@v-aaditya v-aaditya commented Jul 30, 2026

Copy link
Copy Markdown
Merge Checklist

All boxes should be checked before merging the PR (just tick any boxes which don't apply to this PR)

  • The toolchain has been rebuilt successfully (or no changes were made to it)
  • The toolchain/worker package manifests are up-to-date
  • Any updated packages successfully build (or no packages were changed)
  • Packages depending on static components modified in this PR (Golang, *-static subpackages, etc.) have had their Release tag incremented.
  • Package tests (%check section) have been verified with RUN_CHECK=y for existing SPEC files, or added to new SPEC files
  • All package sources are available
  • cgmanifest files are up-to-date and sorted (./cgmanifest.json, ./toolkit/scripts/toolchain/cgmanifest.json, .github/workflows/cgmanifest.json)
  • LICENSE-MAP files are up-to-date (./LICENSES-AND-NOTICES/SPECS/data/licenses.json, ./LICENSES-AND-NOTICES/SPECS/LICENSES-MAP.md, ./LICENSES-AND-NOTICES/SPECS/LICENSE-EXCEPTIONS.PHOTON)
  • All source files have up-to-date hashes in the *.signatures.json files
  • sudo make go-tidy-all and sudo make go-test-coverage pass
  • Documentation has been updated to match any changes to the build system
  • Ready to merge

Summary
  • Upgrade nodejs from version 24.18.0 => 24.18.1.
  • All the existing CVE patches are retained as they affect the upgraded version of nodejs. Details are as follows -
    • The build uses two separate jinja2 vendor package copies, both are still at vulnerable versions, so their patches are still required -
      • tools/inspector_protocol/jinja2 = 2.10 (imported by nodejs's inspector codegen via src/inspector/node_inspector.gypideps/inspector_protocol/code_generator.py) → CVE-2019-10906, CVE-2020-28493
      • deps/v8/third_party/jinja2 = 3.1.2 (imported by V8's inspector codegen via tools/v8_gypfiles/v8.gyp) → CVE-2024-22195, CVE-2024-34064, CVE-2025-27516
    • The two undici patches target npm's bundled undici version 6.26.0, which is still affected → CVE-2026-12151, CVE-2026-9679 retained.
  • Few patches are updated as the offset has changed for them.
  • This upgrade also fixes CVE-2026-56846, CVE-2026-56848, CVE-2026-58043, CVE-2026-56850, CVE-2026-58040,
    CVE-2026-58041, CVE-2026-58042, CVE-2026-58045, CVE-2026-56847, CVE-2026-58039, CVE-2026-58044
  • This upgrade also updates dependencies: llhttp to version 9.4.3 and undici to version 7.29.0.
  • Release log - https://github.com/nodejs/node/releases/tag/v24.18.1
Change Log
  • modified: SPECS/nodejs/CVE-2025-27516.patch
  • modified: SPECS/nodejs/disable-tlsv1-tlsv1-1.patch
  • modified: SPECS/nodejs/nodejs.signatures.json
  • modified: SPECS/nodejs/nodejs.spec
  • modified: cgmanifest.json
Does this affect the toolchain?

NO

Links to CVEs
Test Methodology
  • Local build could not be triggered due to resource limitation.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@microsoft-github-policy-service microsoft-github-policy-service Bot added Packaging 3.0-dev PRs Destined for AzureLinux 3.0 labels Jul 30, 2026
@Kanishk-Bansal Kanishk-Bansal added security CVE-fixed-by-upgrade CVE fixed by package upgrade labels Jul 30, 2026
@v-aaditya

v-aaditya commented Jul 30, 2026

Copy link
Copy Markdown
Author

Updated source tarball uploaded on blob store - Link
Triggered Buddy Build and it has passed.

Peer-reviewed by @akhila-guruju.
This PR is ready for FTE review.

@v-aaditya v-aaditya changed the title Upgrade nodejs to version 24.18.1 Upgrade nodejs to version 24.18.1 to fix CVE-2026-56846, CVE-2026-56848, CVE-2026-58043, CVE-2026-56850, CVE-2026-58040, CVE-2026-58041, CVE-2026-58042, CVE-2026-58045, CVE-2026-56847, CVE-2026-58039, CVE-2026-58044 Jul 30, 2026
@Kanishk-Bansal
Kanishk-Bansal marked this pull request as ready for review July 30, 2026 07:42
@Kanishk-Bansal
Kanishk-Bansal requested a review from a team as a code owner July 30, 2026 07:42

@Kanishk-Bansal Kanishk-Bansal left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Micro version bump to fix the CVEs.

  • Buddy Build
  • Tarball uploaded
  • Changelog entry
  • CG Manifest
  • PR has security & CVE-fixed-by-upgrade tag

@Kanishk-Bansal Kanishk-Bansal added the ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review label Jul 30, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

3.0-dev PRs Destined for AzureLinux 3.0 CVE-fixed-by-upgrade CVE fixed by package upgrade Packaging ready-for-stable-review PR has passed initial review and is now ready for a second-level stable maintainer review security

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants