Skip to content

feat(kernel): Enable ghes acpi kernel config option - #18224

Open
AZaugg wants to merge 3 commits into
microsoft:4.0from
AZaugg:azaugg/4.0/GHES_ACPI-enable
Open

feat(kernel): Enable ghes acpi kernel config option#18224
AZaugg wants to merge 3 commits into
microsoft:4.0from
AZaugg:azaugg/4.0/GHES_ACPI-enable

Conversation

@AZaugg

@AZaugg AZaugg commented Jul 27, 2026

Copy link
Copy Markdown
Contributor

Reenable CONFIG_ACPI_APEI_GHES for azurelinux 4.

This is a series of PRs, look at
#17874

first

AZaugg and others added 2 commits July 27, 2026 15:04
Set CONFIG_INFINIBAND_BNXT_RE=m, reenabling RDMA support on
Broadcom NetXtreme NICs. Bump azl_pkgrelease to 10 with a
%changelog entry and refresh the kernel lock input-fingerprint.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Enable CONFIG_ACPI_APEI_GHES=y (Generic Hardware Error Source) in the
x86_64 kernel config to support APEI/GHES firmware-first hardware error
reporting. aarch64 already has GHES enabled. All select dependencies
(ACPI_HED, IRQ_WORK, GENERIC_ALLOCATOR) and the ACPI_APEI dependency are
already satisfied, so this is an additive change.

Bumps azl_pkgrelease 10 -> 11 with a matching changelog entry.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot AI review requested due to automatic review settings July 27, 2026 19:32
@AZaugg
AZaugg requested a review from a team as a code owner July 27, 2026 19:32
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@AZaugg AZaugg changed the title Azaugg/4.0/ghes acpi enable feat(kernel): Enable ghes acpi kernel config option Jul 27, 2026

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Enables ACPI APEI GHES on x86_64, stacked on the preceding Broadcom RoCE change.

Changes:

  • Enables CONFIG_ACPI_APEI_GHES=y.
  • Retains stacked CONFIG_INFINIBAND_BNXT_RE=m changes.
  • Updates policy, release metadata, rendered files, and lock fingerprint.

The implementation is consistent, but the PR title fails the required Conventional Commits validation.

Reviewed changes

Copilot reviewed 7 out of 8 changed files in this pull request and generated no comments.

Show a summary per file
File Description
base/comps/kernel/6.18-x86_64-azl.config Enables GHES and stacked BNXT_RE settings.
base/comps/kernel/kernel.azl.macros Advances package release to 11.
base/comps/kernel/kernel.spec Adds release changelog entries.
locks/kernel.lock Refreshes the component fingerprint.
scripts/ci/kernel/kernel-config-checker/kernel_config_checker/kernel_configs_json/azl4-os-required-kernel-configs.json Enforces the new x86_64 settings.
specs/k/kernel/6.18-x86_64-azl.config Updates rendered kernel configuration.
specs/k/kernel/kernel.azl.macros Updates rendered release metadata.
specs/k/kernel/kernel.spec Updates rendered changelog.

Copilot AI review requested due to automatic review settings July 29, 2026 22:07

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Copilot reviewed 7 out of 8 changed files in this pull request and generated no new comments.

Comments suppressed due to low confidence (1)

scripts/ci/kernel/kernel-config-checker/kernel_config_checker/kernel_configs_json/azl4-os-required-kernel-configs.json:3248

  • Rebase this stacked branch onto the latest #17874. That prerequisite now removes this kernel-specific override because the default entry already requires m, and it updates the default justification. Keeping this copy would reintroduce stale, duplicate policy and lose the prerequisite's reviewed justification when the series lands.
          "name": "CONFIG_INFINIBAND_BNXT_RE",
          "values": [
            { "architecture": "x86_64", "value": "m" }
          ],
          "justification": "https://microsoft.visualstudio.com/OS/_workitems/edit/63295045"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants