Add explicit R1CS witness blinding API - #506
Merged
Srinath Setty (srinathsetty) merged 9 commits intoAug 19, 2026
Merged
Conversation
Sai (sai-deng)
force-pushed
the
sai/required-proof-randomness
branch
from
August 10, 2026 02:49
d61f7ba to
96b0f09
Compare
Srinath Setty (srinathsetty)
requested review from
Wilson Nguyen (MercysJest),
iontzialla and
Srinath Setty (srinathsetty)
August 14, 2026 16:29
Wilson Nguyen (MercysJest)
approved these changes
Aug 14, 2026
Wilson Nguyen (MercysJest)
left a comment
Contributor
There was a problem hiding this comment.
LGTM!
Srinath Setty (srinathsetty)
approved these changes
Aug 19, 2026
Srinath Setty (srinathsetty)
left a comment
Collaborator
There was a problem hiding this comment.
LGTM, left one minor nit.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
R1CSWitnessBlindas a typed witness-commitment blind_with_blindvariants on the existingNovaWitnesstrait andR1CSWitnesstype for deterministic protocolsnova-snark0.74.0Why
Normal callers should not need to manage commitment randomness. The typed explicit path makes that exceptional ownership visible without passing bare scalars or adding a second trait.
API
Validation