Skip to content

fix(cmake): find_package(GTest) before pkg-config / download (#1256) #1260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Sofia Martin (sofiamartincraft) wants to merge 1 commit into
base: main
Choose a base branch
from
+10 −1
Open

fix(cmake): find_package(GTest) before pkg-config / download (#1256) #1260

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion tests/CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,16 @@ if(IOS)
add_compile_definitions(GTEST_HAS_DEATH_TEST=1 IOS_PROCESS_DELAY_WORKAROUND=1)
endif()

pkg_search_module(GTestMain gtest_main)
# Prefer CMake package config (vcpkg / most package managers) before pkg-config,
# which is often unavailable on Windows (#1256).
find_package(GTest QUIET)
if (GTest_FOUND)
set(GTestMain_FOUND TRUE)
set(GTestMain_LIBRARIES GTest::gtest_main)
else()
pkg_search_module(GTestMain gtest_main)
endif()

if (NOT GTestMain_FOUND)
# No pre-installed GTest is available, try to download it using Git.
find_package(Git REQUIRED QUIET)
Expand Down