Skip to content
Open
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
48 changes: 43 additions & 5 deletions Inc/Effects.h
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@
DIRECTX_TOOLKIT_API void __cdecl SetSpecularTexture(D3D12_GPU_DESCRIPTOR_HANDLE srvDescriptor);

protected:
// Private implementation.
// internal implementation.
class Impl;

std::unique_ptr<Impl> pImpl;
Expand Down Expand Up @@ -663,7 +663,7 @@
DIRECTX_TOOLKIT_API void __cdecl SetRenderTargetSizeInPixels(int width, int height);

protected:
// Private implementation.
// Internal implementation.
class Impl;

std::unique_ptr<Impl> pImpl;
Expand All @@ -674,6 +674,7 @@
const EffectPipelineStateDescription& pipelineDescription,
bool skinningEnabled);

private:
// Unsupported interface methods.
DIRECTX_TOOLKIT_API void XM_CALLCONV SetAmbientLightColor(FXMVECTOR value) override;
DIRECTX_TOOLKIT_API void XM_CALLCONV SetLightSpecularColor(int whichLight, FXMVECTOR value) override;
Expand Down Expand Up @@ -763,11 +764,13 @@
Mode_MatCap, // Material Capture shading
};

DIRECTX_TOOLKIT_API NPREffect(

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, ON, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Debug-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport

Check failure on line 767 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (x64-Release-MinGW, ON, OFF, windows-2025)

function 'DirectX::DX12::NPREffect::NPREffect(ID3D12Device*, uint32_t, const DirectX::EffectPipelineStateDescription&, Mode)' definition is marked dllimport
_In_ ID3D12Device* device,
uint32_t effectFlags,
const EffectPipelineStateDescription& pipelineDescription,
Mode nprMode = Mode_Cel);
Mode nprMode = Mode_Cel) :
NPREffect(device, effectFlags, pipelineDescription, nprMode, false)
{}

DIRECTX_TOOLKIT_API NPREffect(NPREffect&&) noexcept;
DIRECTX_TOOLKIT_API NPREffect& operator= (NPREffect&&) noexcept;
Expand Down Expand Up @@ -821,19 +824,54 @@
DIRECTX_TOOLKIT_API void __cdecl SetRimLightingRange(float start, float end);
DIRECTX_TOOLKIT_API void __cdecl DisableRimLighting();

private:
// Private implementation.
protected:
// Internal implementation.
class Impl;

std::unique_ptr<Impl> pImpl;

DIRECTX_TOOLKIT_API NPREffect(
_In_ ID3D12Device* device,
uint32_t effectFlags,
const EffectPipelineStateDescription& pipelineDescription,
Mode nprMode,
bool skinningEnabled);

private:
// Unsupported interface methods.
DIRECTX_TOOLKIT_API void XM_CALLCONV SetAmbientLightColor(FXMVECTOR value) override;
DIRECTX_TOOLKIT_API void __cdecl SetLightEnabled(int whichLight, bool value) override;
DIRECTX_TOOLKIT_API void XM_CALLCONV SetLightDiffuseColor(int whichLight, FXMVECTOR value) override;
DIRECTX_TOOLKIT_API void XM_CALLCONV SetLightSpecularColor(int whichLight, FXMVECTOR value) override;
};

class DIRECTX_TOOLKIT_API SkinnedNPREffect : public NPREffect, public IEffectSkinning
{
public:
SkinnedNPREffect(
_In_ ID3D12Device* device,
uint32_t effectFlags,
const EffectPipelineStateDescription& pipelineDescription,
Mode nprMode = Mode_Cel) :
NPREffect(device, effectFlags, pipelineDescription, nprMode, true)
{}

SkinnedNPREffect(SkinnedNPREffect&&) = default;
SkinnedNPREffect& operator= (SkinnedNPREffect&&) = default;

SkinnedNPREffect(SkinnedNPREffect const&) = delete;
SkinnedNPREffect& operator= (SkinnedNPREffect const&) = delete;

~SkinnedNPREffect() override;

// IEffect methods.
DIRECTX_TOOLKIT_API void __cdecl Apply(_In_ ID3D12GraphicsCommandList* commandList) override;

Check failure on line 868 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (14, x64-Debug-VCPKG, amd64, ON, ON)

'Apply': member of dll interface class may not be declared with dll interface

Check failure on line 868 in Inc/Effects.h

View workflow job for this annotation

GitHub Actions / build (14, x64-Debug-VCPKG, amd64, ON, ON)

'Apply': member of dll interface class may not be declared with dll interface
Comment thread
walbourn marked this conversation as resolved.
Outdated

// Animation settings.
void __cdecl SetBoneTransforms(_In_reads_(count) XMMATRIX const* value, size_t count) override;
void __cdecl ResetBoneTransforms() override;
};


//------------------------------------------------------------------------------
// Abstract interface to factory texture resources
Expand Down
Loading
Loading