[#646] JS OTel sample leaves an open connection when shutting down#649
Open
ceciliaavila wants to merge 3 commits into
Open
[#646] JS OTel sample leaves an open connection when shutting down#649ceciliaavila wants to merge 3 commits into
ceciliaavila wants to merge 3 commits into
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This pull request updates the Node.js OpenTelemetry (OTel) sample to shut down the OTel SDK more reliably (to avoid lingering connections on restart) and expands tracing coverage by adding Undici (fetch) instrumentation.
Changes:
- Adds a guarded shutdown handler with a timeout and explicit process exit after
sdk.shutdown(). - Enables
AlwaysOnSamplerto ensure traces are always sampled. - Adds
@opentelemetry/instrumentation-undiciand wiresUndiciInstrumentationinto the SDK.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| samples/nodejs/otel/src/instrumentation.ts | Updates SDK configuration (sampler + instrumentations) and improves shutdown handling to avoid lingering resources. |
| samples/nodejs/otel/package.json | Bumps OpenTelemetry dependencies and adds Undici instrumentation dependency. |
| samples/nodejs/otel/package-lock.json | Updates lockfile to reflect the new/updated OpenTelemetry dependency graph. |
Files not reviewed (1)
- samples/nodejs/otel/package-lock.json: Generated file
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #646
Description
This pull request enhances OpenTelemetry instrumentation for the Node.js sample by improving the SDK shutdown process. It also adds support for Undici HTTP client tracing to have observability over fetch requests.
Detailed Changes
AlwaysOnSamplerfor tracing to ensure all traces are captured.@opentelemetry/instrumentation-undicias a dependency and enabledUndiciInstrumentationin the SDK configuration to support tracing for the Undici HTTP client.Testing
These images show the sample successfully restarted and the traces properly exported.
