Skip to content

feat: make header narrower#24

Open
dharapandya85 wants to merge 5 commits into
metakgp:mainfrom
dharapandya85:feature-narrow-header
Open

feat: make header narrower#24
dharapandya85 wants to merge 5 commits into
metakgp:mainfrom
dharapandya85:feature-narrow-header

Conversation

@dharapandya85

@dharapandya85 dharapandya85 commented Dec 10, 2025

Copy link
Copy Markdown

Description

Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR fixes the header width. The header uses inner wrapper(.header-inner) with a max-width.
Fixes #19 (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Verified visually on desktop screens of various widths

Test Configuration:
Windows 11 Operating System, React 18.2, Node.js 22.18.0,

  • Firmware version:
  • Hardware:
  • Toolchain:
  • SDK:

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules
Screenshot (185)

@Majestic9169

Copy link
Copy Markdown
Collaborator

please request reviews guys 😭

@Majestic9169
Majestic9169 force-pushed the main branch 3 times, most recently from d884e79 to faab721 Compare December 17, 2025 20:57

@Majestic9169 Majestic9169 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

seems to mess up responsiveness, please look into it

@dharapandya85

Copy link
Copy Markdown
Author

Please check now.
Screenshot (220)

@Majestic9169

Copy link
Copy Markdown
Collaborator

responsiveness has been fixed, but the purpose of this issue was to have the header aligned with the content on larger screens

image

.header-inner{
display: flex;
width: 100%;
max-width: 1100px;

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pretty sure its an issue with the max-width, on my screen the hero section takes 1228px on full screen, making it impossible to align with 1100px max width.

hardcoding these values is probably not the best way, please look for something better

@dharapandya85

Copy link
Copy Markdown
Author

About page now aligns header and container section.

Screenshot (242)

Projects, Contribute, DC++, pages might show little bit different UI,
also, responsive(mobile) view may be little different, waiting for feedback on this.

@Majestic9169

Copy link
Copy Markdown
Collaborator

your changes to page-container break everything lmao, i'm sorry but i can't allow a breaking change like that. please revert that last commit we absolutely can not have a change like that.

@dharapandya85

Copy link
Copy Markdown
Author

Please check now.
Screenshot (301)

@Majestic9169

Copy link
Copy Markdown
Collaborator
image

i'm sorry but something is clearly wrong

we may have to consider if this issue is worth the effort

@Majestic9169 Majestic9169 left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

doesn't work on my machine :(, very noticeable offset between header and hero section

@dharapandya85

Copy link
Copy Markdown
Author

Will modify again, if there is an issue, right now, header is aligned with rest of the content.
Screenshot (313)

What I did now:
-> synced with the latest commit
-> will remove extra container from header.jsx and hero.jsx
-> if responsiveness not proper, will correct it.

@dharapandya85

Copy link
Copy Markdown
Author

Any update here @Majestic9169 , will resolve conflicts

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Narrower Header

2 participants