feat: make header narrower#24
Open
dharapandya85 wants to merge 5 commits into
Open
Conversation
Collaborator
|
please request reviews guys 😭 |
Majestic9169
force-pushed
the
main
branch
3 times, most recently
from
December 17, 2025 20:57
d884e79 to
faab721
Compare
Author
Collaborator
Majestic9169
requested changes
Dec 23, 2025
| .header-inner{ | ||
| display: flex; | ||
| width: 100%; | ||
| max-width: 1100px; |
Collaborator
There was a problem hiding this comment.
pretty sure its an issue with the max-width, on my screen the hero section takes 1228px on full screen, making it impossible to align with 1100px max width.
hardcoding these values is probably not the best way, please look for something better
Author
Collaborator
|
your changes to |
Author
Collaborator
Majestic9169
requested changes
Jan 11, 2026
Majestic9169
left a comment
Collaborator
There was a problem hiding this comment.
doesn't work on my machine :(, very noticeable offset between header and hero section
dharapandya85
force-pushed
the
feature-narrow-header
branch
from
January 12, 2026 11:23
2a5a95d to
5c2cbc5
Compare
Author
Author
|
Any update here @Majestic9169 , will resolve conflicts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.







Description
Please include a summary of the changes and the related issue. Please also include relevant motivation and context. List any dependencies that are required for this change.
This PR fixes the header width. The header uses inner wrapper(
.header-inner) with amax-width.Fixes #19 (issue)
Type of change
Please delete options that are not relevant.
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Test Configuration:
Windows 11 Operating System, React 18.2, Node.js 22.18.0,
Checklist: