Skip to content

fix(sx126x): do not assert when setStandby fails #11632

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wormuz wants to merge 1 commit into
base: develop
Choose a base branch
from
+6 −2
Open

fix(sx126x): do not assert when setStandby fails #11632

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/mesh/SX126xInterface.cpp
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -323,12 +323,16 @@ template <typename T> void SX126xInterface<T>::setStandby()
int err = lora.standby();

if (err != RADIOLIB_ERR_NONE)
LOG_DEBUG("SX126x standby %s%d", radioLibErr, err);
LOG_WARN("SX126x standby failed %s%d", radioLibErr, err);
#ifdef ARCH_PORTDUINO
if (err != RADIOLIB_ERR_NONE)
portduino_status.LoRa_in_error = true;
#else
assert(err == RADIOLIB_ERR_NONE);
// Do not assert. setStandby() runs on the radio thread from inside the TX
// path, so an assert kills that thread silently: the queued packet is never
// sent, every counter stays at zero and the log just stops mid-trace with no
// hint why. A failed standby is recoverable - the next startReceive() or
// startSend() reissues the mode change - so warn and carry on.
#endif
isReceiving = false; // If we were receiving, not any more
activeReceiveStart = 0;
Expand Down