stm32wl: enable LSE/RTC/deep-sleep on all variants - #11491
Conversation
⚡ Try this PR in the Web FlasherNote Building this pull request… the flash button, badges and supported-board |
|
Note Reviews pausedIt looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the Use the following commands to manage reviews:
Use the checkboxes below for quick actions:
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Pro Plus Run ID: 📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
Included review availability: Your plan provides up to 8 included reviews per hour; 7 remain after this review. 📝 WalkthroughWalkthroughSTM32WL variant headers now configure low-drive LSE support. Shared STM32 settings add RTC and low-power dependencies, air-quality exclusion, and recoverable LittleFS assertions. Selected environments remove duplicate dependencies and local air-quality exclusions. ChangesSTM32 support updates
Estimated code review effort: 2 (Simple) | ~10 minutes Merge Risk: ⚪ Minimal · up to This change enables RTC and low-power support across STM32WL variants and adjusts shared build configuration. No actionable merge-blocking risk remains beyond normal checks and review. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
Full details: Docstring CoverageExplanation No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 4 files. (1 skipped: 1 unsupported.) ✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Action performedReview finished.
|
833f8aa to
365dd17
Compare
365dd17 to
38479b8
Compare
|
Note GitHub couldn't provide a complete incremental comparison for this pull request, so CodeRabbit is performing a full review instead. This review may take a little longer. |
|
@coderabbitai review |
|
Recent flash-savings work now allows RTC & LowPower libraries to fit on all STM32WL variants. - Add STM32RTC/STM32LowPower lib_deps to stm32_base environment - Drop lib_deps from variants where RTC & LowPower are now redundant: - rak3172 - nucleo_wl55jc - Define HAS_LSE & LSEDRIVE level macros on remaining STM32WL variants: - russell - wio-e5 - CDEBYTE_E77-MBL - milesight_gs301 - Move MESHTASTIC_EXCLUDE_AIR_QUALITY_SENSOR into stm32_base and drop the per-variant copies. No STM32WL variant has populated air-quality hardware, and excluding it in the base is what keeps nucleo_wl55jc within its flash budget. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Andrew Yong <me@ndoo.sg>
38479b8 to
8f12df9
Compare
Resolves additive conflicts in variants/stm32/CDEBYTE_E77-MBL/variant.h and variants/stm32/wio-e5/variant.h: upstream meshtastic#10964 adds TCXO macros next to this branch's HAS_LSE/STM32WL_LSE_DRIVE defines; both blocks are kept. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Andrew Yong <me@ndoo.sg>
|
Resolves an additive conflict in variants/stm32/stm32.ini: upstream reordered the shared MESHTASTIC_EXCLUDE build flags and added MESHTASTIC_EXCLUDE_RTTTL while this branch added MESHTASTIC_EXCLUDE_AIR_QUALITY_SENSOR; both flags are kept. Assisted-by: Claude Sonnet 5 <noreply@anthropic.com> Signed-off-by: Andrew Yong <me@ndoo.sg>
|
Merge of #10989 caused a conflict here which has now been fixed. Took the reordered block and kept the branch's AIR_QUALITY_SENSOR flag alongside it. No flags dropped. |
Summary
Recent flash-savings work now allows RTC & LowPower libraries to fit on all STM32WL variants.
STM32RTC/STM32LowPowerlib_depsto thestm32_baseenvironmentlib_depsfrom variants where RTC & LowPower are now redundant:rak3172nucleo_wl55jcHAS_LSE&STM32WL_LSE_DRIVEmacros on the remaining STM32WL variants:russellwio-e5CDEBYTE_E77-MBLmilesight_gs301MESHTASTIC_EXCLUDE_AIR_QUALITY_SENSORintostm32_baseand drop the per-variant copies. No STM32WL variant has populated air-quality hardware, and excluding it in the shared base is what bringsnucleo_wl55jcback under its flash budget.Flash usage
Rebased onto
developat 7e9525a. Allocated flash is 242.0 KiB (247808 B) on every STM32WL variant.milesight_gs301fails to build due to a pre-existingdeveloperror unrelated to this change (PIO_FRAMEWORK_ARDUINO_NANOLIB_FLOAT_PRINTFguard inarchitecture.h). Fixed separately in #11649.🤝 Attestations
rak3172flashed, check for RTC init, set RTC, reboot, readback RTCrussellflashed, booted (no further test - functionally identical to rak3172)CDEBYTE_E77-MBLflashed, check for RTC init, set RTC, reboot, readback RTCwio-e5flashed, check for RTC init, set RTC, reboot, readback RTCnucleo_wl55jcflashed, check for RTC init, set RTC, reboot, readback RTCmilesight_gs301not tested due to pre-existing build errorrak3172,russell,wio-e5,CDEBYTE_E77-MBL,nucleo_wl55jcSet RTC/Readback RTC Procedure
meshtastic --port <port> --set-timereadFromRTC epoch=... acceptedSummary by CodeRabbit
New Features
Build Improvements