Update README to clarify multi-line blocks#142
Open
Emmanuel-R8 wants to merge 2 commits into
Open
Conversation
mcabbott
reviewed
Mar 10, 2022
Comment on lines
+282
to
+285
| @tullio D[i, j] := begin | ||
| TMP[i, j, m, n] = A[i, j, k, l] * B[k, l, m, n] | ||
| TMP[i, j, m, n] * C[m, n] | ||
| end |
Owner
There was a problem hiding this comment.
I guess this one is safe, but I'm not keen to encourage such use. Tullio will often multi-thread over indices it deems safe, but it is not smart enough to notice that this is writing into an array. If it had TMP[j, m, n] = , this would introduce data races.
Author
There was a problem hiding this comment.
Then I think I should had a comment to that effect. It is another difference with single liners.
Emmanuel-R8
commented
Mar 10, 2022
Emmanuel-R8
left a comment
Emmanuel-R8
left a comment
Author
There was a problem hiding this comment.
Add text about data races when using the same symbol within a block.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.