Skip to content

fix(facts): use RPM shortDesc for ESC rotation rate#14634

Closed
Bartok9 wants to merge 2 commits into
mavlink:masterfrom
Bartok9:aerial/esc-rpm-shortDesc-2026-07-18
Closed

fix(facts): use RPM shortDesc for ESC rotation rate#14634
Bartok9 wants to merge 2 commits into
mavlink:masterfrom
Bartok9:aerial/esc-rpm-shortDesc-2026-07-18

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

What

Replace EscStatus rpm shortDesc "Rotation Per Minute" with the standard abbreviation RPM.

Motivation

Telemetry panels are dense; RPM is universal and matches generator fact style (units: rpm).

Verification

JSON-only metadata; no unit conversion change.

Reviewed by hand on master tip.

Match common telemetry labeling; units remain implied by value.
@github-actions

github-actions Bot commented Jul 18, 2026

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 31 passed, 0 skipped
linux-coverage-unit: 106 passed, 0 skipped
Total: 137 passed, 0 skipped

Code Coverage

Coverage: 67.6%

No baseline available for comparison

Artifact Sizes

Artifact Size
QGroundControl 221.84 MB
QGroundControl-aarch64 179.42 MB
QGroundControl-installer-AMD64 137.95 MB
QGroundControl-installer-AMD64-ARM64 80.46 MB
QGroundControl-installer-ARM64 109.20 MB
QGroundControl-linux 87.09 MB
QGroundControl-mac 87.09 MB
QGroundControl-windows 86.15 MB
QGroundControl-x86_64 191.65 MB
No baseline available for comparison

Updated: 2026-07-18 12:25:42 UTC • Commit: 339df65 • Triggered by: Android

@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.49%. Comparing base (f29efd3) to head (339df65).
⚠️ Report is 147 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14634      +/-   ##
==========================================
+ Coverage   25.47%   31.49%   +6.02%     
==========================================
  Files         769      785      +16     
  Lines       65912    66935    +1023     
  Branches    30495    31023     +528     
==========================================
+ Hits        16788    21082    +4294     
+ Misses      37285    31539    -5746     
- Partials    11839    14314    +2475     
Flag Coverage Δ
unittests 31.49% <ø> (+6.02%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 454 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 38d6913...339df65. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Bartok9

Bartok9 commented Jul 19, 2026

Copy link
Copy Markdown
Contributor Author

Consolidating per @DonLakeFlyer's request into a single PR: #14651. Closing this one. Thanks!

@Bartok9 Bartok9 closed this Jul 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant