Skip to content

fix(facts): use vertical m for submarine rangefinder distance facts#14620

Open
Bartok9 wants to merge 3 commits into
mavlink:masterfrom
Bartok9:aerial/submarine-rf-vertical-m-2026-07-17
Open

fix(facts): use vertical m for submarine rangefinder distance facts#14620
Bartok9 wants to merge 3 commits into
mavlink:masterfrom
Bartok9:aerial/submarine-rf-vertical-m-2026-07-17

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Set SubmarineFact rangefinderDistance and rangefinderTarget units to vertical m.

Motivation

ROV rangefinder range/target are vertical-axis lengths. Plain m skips Vertical Distance unit conversion.

Verification

  • JSON OK; two unit fields only
  • No vehicle control changes

Notes

AI-assisted; human-reviewed. Complements prior vertical-m fact work (DonLakeFlyer coalesce credited earlier merges).

@codecov

codecov Bot commented Jul 17, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.20%. Comparing base (f29efd3) to head (82bb408).
⚠️ Report is 141 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14620      +/-   ##
==========================================
+ Coverage   25.47%   31.20%   +5.73%     
==========================================
  Files         769      785      +16     
  Lines       65912    66906     +994     
  Branches    30495    31007     +512     
==========================================
+ Hits        16788    20879    +4091     
+ Misses      37285    31822    -5463     
- Partials    11839    14205    +2366     
Flag Coverage Δ
unittests 31.20% <ø> (+5.73%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 445 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 57b8c85...82bb408. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

⚠️ Build results unavailable — artifact download from one or more platform workflows failed (likely artifact retention expiry or transient API error). The combined report cannot be generated for this run.

See the Build Results workflow run for details.

@Bartok9
Bartok9 force-pushed the aerial/submarine-rf-vertical-m-2026-07-17 branch from 82bb408 to 8f52999 Compare July 17, 2026 20:23
Rangefinder range and target are vertical-axis lengths for ROV displays.
Plain "m" skips Vertical Distance unit preference conversion.
@Bartok9
Bartok9 force-pushed the aerial/submarine-rf-vertical-m-2026-07-17 branch from 8f52999 to e5537a4 Compare July 18, 2026 20:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant