Skip to content

fix(facts): use vertical m for distance-sensor up/down ranges#14617

Open
Bartok9 wants to merge 1 commit into
mavlink:masterfrom
Bartok9:aerial/distancesensor-vertical-m-2026-07-17
Open

fix(facts): use vertical m for distance-sensor up/down ranges#14617
Bartok9 wants to merge 1 commit into
mavlink:masterfrom
Bartok9:aerial/distancesensor-vertical-m-2026-07-17

Conversation

@Bartok9

@Bartok9 Bartok9 commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Tag DistanceSensorFact rotationPitch90 (Up) and rotationPitch270 (Down) units as vertical m.

Motivation

Plain m is treated as horizontal distance by FactMetaData. Up/down rangefinder ranges are vertical lengths; they should honor the Vertical Distance units setting. Lateral yaw ranges and min/max stay m.

Verification

  • JSON parses
  • Only pitch-up/down unit fields changed
  • No flight/arm/geofence code paths touched

Notes

AI-assisted; human-reviewed. Spec: specs/qgroundcontrol/2026-07-17-1.md (Composer 2.5 Standard intent).

@github-actions

github-actions Bot commented Jul 17, 2026

Copy link
Copy Markdown
Contributor

Build Results

Platform Status

Platform Status Details
Linux Passed View
Windows Passed View
MacOS Passed View
Android Passed View

All builds passed.

Pre-commit

Check Status Details
pre-commit Failed (non-blocking) View

Pre-commit hooks: 0 passed, 0 failed, 0 skipped.

Test Results

linux-coverage-integration: 33 passed, 0 skipped
linux-coverage-unit: 107 passed, 0 skipped
Total: 140 passed, 0 skipped

Code Coverage

Coverage Baseline Change
67.7% 67.7% -0.0%

Artifact Sizes

Artifact Size Δ from master
QGroundControl 221.84 MB -4.46 MB (decrease)
QGroundControl-aarch64 179.44 MB No change
QGroundControl-installer-AMD64 137.93 MB -0.46 MB (decrease)
QGroundControl-installer-AMD64-ARM64 80.45 MB -0.19 MB (decrease)
QGroundControl-installer-ARM64 109.22 MB +0.01 MB (increase)
QGroundControl-linux 87.10 MB -78.80 MB (decrease)
QGroundControl-mac 87.09 MB No change
QGroundControl-windows 86.16 MB No change
QGroundControl-x86_64 191.65 MB No change
Total size decreased by 83.90 MB

Updated: 2026-07-18 21:22:21 UTC • Commit: fa6e85c • Triggered by: Android

@Bartok9
Bartok9 force-pushed the aerial/distancesensor-vertical-m-2026-07-17 branch from 92f6a49 to 1127683 Compare July 17, 2026 20:23
Pitch-up and pitch-down rangefinder distances are vertical axis lengths.
Tagging them as plain "m" makes Vertical Distance units settings skip them.
@Bartok9
Bartok9 force-pushed the aerial/distancesensor-vertical-m-2026-07-17 branch from 1127683 to fa6e85c Compare July 18, 2026 20:28
@codecov

codecov Bot commented Jul 18, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 31.51%. Comparing base (f29efd3) to head (fa6e85c).
⚠️ Report is 152 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master   #14617      +/-   ##
==========================================
+ Coverage   25.47%   31.51%   +6.04%     
==========================================
  Files         769      785      +16     
  Lines       65912    66968    +1056     
  Branches    30495    31013     +518     
==========================================
+ Hits        16788    21105    +4317     
+ Misses      37285    31568    -5717     
- Partials    11839    14295    +2456     
Flag Coverage Δ
unittests 31.51% <ø> (+6.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.
see 455 files with indirect coverage changes


Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6487625...fa6e85c. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant