Skip to content

connector: backfill DM peer UserInfo on resync#287

Open
Fizzadar wants to merge 1 commit into
mainfrom
nick/dm-peer-userinfo
Open

connector: backfill DM peer UserInfo on resync#287
Fizzadar wants to merge 1 commit into
mainfrom
nick/dm-peer-userinfo

Conversation

@Fizzadar

Copy link
Copy Markdown
Member

No description provided.

@tulir

tulir commented Jun 16, 2026

Copy link
Copy Markdown
Member

Hmm, this looks wrong too because makeMinimalChatInfo already adds member entries for DMs. Is the problem that FBChatResync.Members contains yourself, but not the other user?

@Fizzadar

Copy link
Copy Markdown
Member Author

Hmm, this looks wrong too because makeMinimalChatInfo already adds member entries for DMs. Is the problem that FBChatResync.Members contains yourself, but not the other user?

Seems like neither are set and we fallthrough to makeMinimalChatInfo but that doesn't include user info, so the room is re-created with no profile on the other user. We also don't have any ghost for mautrix to pull the profile from.

I have not reproduced this directly, however.

@tulir

tulir commented Jun 17, 2026

Copy link
Copy Markdown
Member

User info is fetched separately if needed. It's only included in the member list if conveniently available

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants