Skip to content

portalbackfill: keep never-bridged messages in forward backfill dedup #517

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Fizzadar wants to merge 2 commits into from
+4 −2
Closed

portalbackfill: keep never-bridged messages in forward backfill dedup #517

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8ec0025
PLAT-36990: keep never-bridged messages in forward backfill dedup
Jun 16, 2026
683e998
comment
Fizzadar Jun 16, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions bridgev2/portalbackfill.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -248,7 +248,9 @@ func (portal *Portal) cutoffMessages(ctx context.Context, messages []*BackfillMe
if lastMessage == nil {
return messages
}
if forward {
if forward && !aggressiveDedup {
// With aggressive dedup, the ID-based pass below decides what's already bridged, so this
// timestamp prefix-trim is skipped.
cutoff := -1
for i, msg := range messages {
if msg.ID == lastMessage.ID || msg.Timestamp.Before(lastMessage.Timestamp) {
Expand All @@ -265,7 +267,7 @@ func (portal *Portal) cutoffMessages(ctx context.Context, messages []*BackfillMe
Msg("Cutting off forward backfill messages older than latest bridged message")
messages = messages[cutoff+1:]
}
} else {
} else if !forward {

@Fizzadar Fizzadar Jun 16, 2026

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we apply the aggressiveDedup guard here too so both forward/backward are the same (aggressive is forced and any prefix shortcuts disabled).

cutoff := -1
for i := len(messages) - 1; i >= 0; i-- {
if messages[i].ID == lastMessage.ID || messages[i].Timestamp.After(lastMessage.Timestamp) {
Expand Down
Loading