bridgev2: allow relayed reactions#510
Open
keithah wants to merge 1 commit into
Open
Conversation
keithah
force-pushed
the
allow-relay-reactions
branch
2 times, most recently
from
9b0d0d7 to
62f3114
Compare
keithah
force-pushed
the
allow-relay-reactions
branch
from
62f3114 to
5102fc7
Compare
keithah
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
bridgev2 currently drops Matrix reactions from relay-level users before they reach the connector. That prevents bridges from implementing network-specific relay reaction behavior.
This passes the original Matrix sender through to
handleMatrixReaction, matching the way message, edit, and delete handling already works. Bridges still decide what to do with the relayed reaction; connectors that do not opt in keep ignoring them through their existing relay checks.I need this for mautrix-discord bridgev2 relay support: relayed Discord messages can be sent with webhooks, but reactions have to go through an authenticated Discord session.
Tested:
go test ./bridgev2/...