ReportHeader - update UI screenshots (feature branch) - #235
Draft
tzi wants to merge 17 commits into
Draft
Conversation
The DataTable search moved from the table footer into the shared ReportHeader (matomo-org/matomo#24986), which changes every report screenshot.
The report header search restyles the shared form controls, which moves the help panel text on the plugin settings page down by a pixel. That was captured on the previous report-header branch, but this branch was cut from 6.x-dev, where the same file had been recaptured for the TrackingSpamPrevention integration (#233) against a core without the restyle, so the adjustment was lost. Byte-identical to what CI renders for the report header branch.
The visualisation switcher and the configure items moved into the menu behind the report header's 3-dots trigger, which twig renders outside the table, so a selector scoped by `[data-report]` no longer reaches them.
Taken from the run that first had the spec change above, so the two flat-page tests reach the flatten entry through the header menu and capture a flattened report instead of erroring before their assertion.
tzi
force-pushed
the
feature-new-report-header
branch
from
August 23, 2026 22:49
fa87895 to
d49d8bc
Compare
Core puts the row of annotation markers back under an evolution graph, which makes the report taller and has its table recompute the column widths.
Drive the report actions from the header menu
The title and the controls beside it line up on their centres, and the two control clusters keep 8px apart. Every report keeps its size.
…carrier Take the image the restored annotations row shifts
Take the images the centred header line produces
6.x-dev draws select fields as a bordered, rounded control instead of Materialize's underlined field, and this page shows one.
The report header lifts Export out of its 3-dots menu into a control of its own, so the line above every full-page report in this plugin changed with it.
The control at the foot of a report takes the shape of the report's other controls, and on a table it moves onto the pagination line.
The control is centred by the pagination line itself now, rather than by a transform that opened a stacking context around it.
It sat flush against the card and now keeps 20px from its right and bottom edges.
A variable name shared with the header's selector had been widening every one of them; these were captured while it did.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Feature branch for the report header work in this plugin: it carries the 7 expected UI screenshots regenerated for the DataTable search moving from the table footer into the shared report header.
Merged into this branch
Impact
None visible to users: expected test screenshots only.
Step by step tests
Nothing to exercise by hand. The screenshots come from the CI artifacts of matomo-org/matomo#24986 and are verified by the core feature branch, matomo-org/matomo#25059.
Note on the UI tests
The plugin's own UI jobs run against core
6.x-dev, which does not yet contain the report header change, so they compare these screenshots against a core that renders the old footer search and go red. They turn green once matomo-org/matomo#25059 lands. Merge this only together with that PR.Checklist