Highlight draft project in sidebar - #147
Merged
Merged
Conversation
📝 WalkthroughWalkthroughDraft project rows now share active sidebar styling and accessibility state with thread rows. Highlight synchronization tracks both persisted thread selection and the project owning the current draft, with an E2E test covering the transition from draft to active thread. ChangesDraft sidebar highlighting
Estimated code review effort: 3 (Moderate) | ~20 minutes Sequence Diagram(s)sequenceDiagram
participant DraftComposer
participant syncActiveThreadHighlight
participant Sidebar
DraftComposer->>syncActiveThreadHighlight: draft project id and thread state
syncActiveThreadHighlight->>Sidebar: set project active and aria-current
DraftComposer->>Sidebar: send message
Sidebar->>syncActiveThreadHighlight: active thread state
syncActiveThreadHighlight->>Sidebar: replace project highlight with thread highlight
Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Comment |
There was a problem hiding this comment.
Actionable comments posted: 1
🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.
Inline comments:
In `@crates/giskard-server/static/app.css`:
- Line 99: Regenerate the mobile screenshot at docs/screenshots/ide-mobile.png
after the sidebar styling change in the app.css rule, ensuring it reflects the
updated styling consistently with the desktop screenshot.
🪄 Autofix (Beta)
Fix all unresolved CodeRabbit comments on this PR:
- Push a commit to this branch (recommended)
- Create a new PR with the fixes
ℹ️ Review info
⚙️ Run configuration
Configuration used: Path: .coderabbit.yaml
Review profile: CHILL
Plan: Pro Plus
Run ID: 6d0f96bc-5377-44e2-a7a4-4d173d26fb07
⛔ Files ignored due to path filters (1)
docs/screenshots/ide-desktop.pngis excluded by!**/*.png,!docs/screenshots/**
📒 Files selected for processing (3)
crates/giskard-server/static/app.csscrates/giskard-server/static/app.jstests/e2e/tests/draft-composer.spec.ts
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary by CodeRabbit