Skip to content

Highlight draft project in sidebar - #147

Merged
marmeladema merged 1 commit into
mainfrom
draft-project-sidebar-selection
Jul 29, 2026
Merged

Highlight draft project in sidebar#147
marmeladema merged 1 commit into
mainfrom
draft-project-sidebar-selection

Conversation

@marmeladema

@marmeladema marmeladema commented Jul 29, 2026

Copy link
Copy Markdown
Owner

Summary by CodeRabbit

  • Bug Fixes
    • Improved sidebar highlighting for active projects and threads.
    • Draft conversations now correctly highlight their associated project.
    • Sidebar selection remains accurate after navigation and re-rendering.
    • Added clearer spacing and visual emphasis for selected projects.

@coderabbitai

coderabbitai Bot commented Jul 29, 2026

Copy link
Copy Markdown

Review Change Stack

📝 Walkthrough

Walkthrough

Draft project rows now share active sidebar styling and accessibility state with thread rows. Highlight synchronization tracks both persisted thread selection and the project owning the current draft, with an E2E test covering the transition from draft to active thread.

Changes

Draft sidebar highlighting

Layer / File(s) Summary
Recompute sidebar selection state
crates/giskard-server/static/app.js
Sidebar selection now uses a shared helper and recomputes active and aria-current state for both thread rows and draft project rows.
Style and validate draft project highlighting
crates/giskard-server/static/app.css, tests/e2e/tests/draft-composer.spec.ts
Project rows receive active and hover styling with updated padding, while the E2E test verifies draft highlighting and the subsequent active thread state.

Estimated code review effort: 3 (Moderate) | ~20 minutes

Sequence Diagram(s)

sequenceDiagram
  participant DraftComposer
  participant syncActiveThreadHighlight
  participant Sidebar
  DraftComposer->>syncActiveThreadHighlight: draft project id and thread state
  syncActiveThreadHighlight->>Sidebar: set project active and aria-current
  DraftComposer->>Sidebar: send message
  Sidebar->>syncActiveThreadHighlight: active thread state
  syncActiveThreadHighlight->>Sidebar: replace project highlight with thread highlight
Loading

Possibly related PRs

Suggested reviewers: claude

🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately summarizes the main change: highlighting the draft project in the sidebar.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
📝 Generate docstrings
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch draft-project-sidebar-selection

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 1

🤖 Prompt for all review comments with AI agents
Verify each finding against current code. Fix only still-valid issues, skip the
rest with a brief reason, keep changes minimal, and validate.

Inline comments:
In `@crates/giskard-server/static/app.css`:
- Line 99: Regenerate the mobile screenshot at docs/screenshots/ide-mobile.png
after the sidebar styling change in the app.css rule, ensuring it reflects the
updated styling consistently with the desktop screenshot.
🪄 Autofix (Beta)

Fix all unresolved CodeRabbit comments on this PR:

  • Push a commit to this branch (recommended)
  • Create a new PR with the fixes

ℹ️ Review info
⚙️ Run configuration

Configuration used: Path: .coderabbit.yaml

Review profile: CHILL

Plan: Pro Plus

Run ID: 6d0f96bc-5377-44e2-a7a4-4d173d26fb07

📥 Commits

Reviewing files that changed from the base of the PR and between 775b7cd and 3b77472.

⛔ Files ignored due to path filters (1)
  • docs/screenshots/ide-desktop.png is excluded by !**/*.png, !docs/screenshots/**
📒 Files selected for processing (3)
  • crates/giskard-server/static/app.css
  • crates/giskard-server/static/app.js
  • tests/e2e/tests/draft-composer.spec.ts

Comment thread crates/giskard-server/static/app.css
@marmeladema
marmeladema merged commit 5c7e114 into main Jul 29, 2026
5 checks passed
@marmeladema
marmeladema deleted the draft-project-sidebar-selection branch July 29, 2026 18:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant