-
Notifications
You must be signed in to change notification settings - Fork 0
feat: add command palette and dialog components #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,189 @@ | ||
| 'use client'; | ||
|
|
||
| import Image from 'next/image'; | ||
| import { useRouter } from 'next/navigation'; | ||
| import { | ||
| CommandDialog, | ||
| CommandEmpty, | ||
| CommandGroup, | ||
| CommandInput, | ||
| CommandItem, | ||
| CommandList, | ||
| } from '@/components/ui/command'; | ||
| import { Button } from './ui/button'; | ||
| import { fetcher, searchCoins } from '@/lib/coingecko.actions'; | ||
| import { Search as SearchIcon } from 'lucide-react'; | ||
| import { useState } from 'react'; | ||
| import { cn } from '@/lib/utils'; | ||
| import useSWR from 'swr'; | ||
| import { useDebounce, useKey } from 'react-use'; | ||
|
|
||
| const TRENDING_LIMIT = 8; | ||
| const SEARCH_LIMIT = 20; | ||
|
|
||
| const SearchItem = ({ coin, onSelect, isActiveName }: SearchItemProps) => { | ||
| return ( | ||
| <CommandItem | ||
| value={coin.id} | ||
| onSelect={() => onSelect(coin.id)} | ||
| className="search-item" | ||
| > | ||
| <div className="coin-info"> | ||
| <Image src={coin.thumb} alt={coin.name} width={40} height={40} /> | ||
|
|
||
| <div> | ||
| <p className={cn('font-bold', isActiveName && 'text-white')}> | ||
| {coin.name} | ||
| </p> | ||
| <p className="coin-symbol">{coin.symbol}</p> | ||
| </div> | ||
| </div> | ||
| </CommandItem> | ||
| ); | ||
| }; | ||
|
markvalenzuela72 marked this conversation as resolved.
|
||
| export async function getTrendingCoins(): Promise<TrendingCoin[]> { | ||
| const res = await fetcher<{ coins: TrendingCoin[] }>( | ||
| '/search/trending', | ||
| undefined, | ||
| 300, | ||
| ); | ||
|
|
||
| return res.coins; | ||
| } | ||
|
|
||
| const SearchModal = () => { | ||
| const router = useRouter(); | ||
| const [open, setOpen] = useState(false); | ||
|
|
||
| const [searchQuery, setSearchQuery] = useState(''); | ||
| const [debouncedQuery, setDebouncedQuery] = useState(''); | ||
|
|
||
| const { data: initialTrendingCoins = [] } = useSWR( | ||
| 'trending-coins', | ||
| getTrendingCoins, | ||
| { | ||
| revalidateOnFocus: false, | ||
| }, | ||
| ); | ||
|
|
||
| useDebounce( | ||
| () => { | ||
| setDebouncedQuery(searchQuery.trim()); | ||
| }, | ||
| 300, | ||
| [searchQuery], | ||
| ); | ||
|
|
||
| const { | ||
| data: searchResults = [], | ||
| isValidating: isSearching, | ||
| error: searchError, | ||
| } = useSWR<SearchCoin[]>( | ||
| debouncedQuery ? ['coin-search', debouncedQuery] : null, | ||
| ([, query]) => searchCoins(query as string), | ||
| { | ||
| revalidateOnFocus: false, | ||
| }, | ||
| ); | ||
|
|
||
| useKey( | ||
| (event) => | ||
| event.key?.toLowerCase() === 'k' && (event.metaKey || event.ctrlKey), | ||
| (event) => { | ||
| event.preventDefault(); | ||
| setOpen((prev) => !prev); | ||
| }, | ||
| {}, | ||
| [setOpen], | ||
| ); | ||
|
|
||
| const handleSelect = (coinId: string) => { | ||
| setOpen(false); | ||
| setSearchQuery(''); | ||
| setDebouncedQuery(''); | ||
| router.push(`/coins/${coinId}`); | ||
| }; | ||
|
|
||
| const hasQuery = debouncedQuery.length > 0; | ||
| const trendingCoins = initialTrendingCoins.slice(0, TRENDING_LIMIT); | ||
| const showTrending = !hasQuery && trendingCoins.length > 0; | ||
|
|
||
| const isSearchEmpty = !isSearching && !hasQuery && !showTrending; | ||
| const isTrendingListVisible = !isSearching && showTrending; | ||
|
|
||
| const isNoResults = !isSearching && hasQuery && searchResults.length === 0; | ||
| const isResultsVisible = !isSearching && hasQuery && searchResults.length > 0; | ||
|
|
||
| return ( | ||
| <div id="search-modal"> | ||
| <Button variant="ghost" onClick={() => setOpen(true)} className="trigger"> | ||
| <SearchIcon size={18} /> | ||
| Search | ||
| <kbd className="kbd"> | ||
| <span className="text-xs">⌘</span>K | ||
| </kbd> | ||
| </Button> | ||
|
|
||
| <CommandDialog | ||
| open={open} | ||
| onOpenChange={setOpen} | ||
| className="dialog" | ||
| data-search-modal | ||
| > | ||
| <div className="cmd-input"> | ||
| <CommandInput | ||
| placeholder="Search for a token by name or symbol..." | ||
| value={searchQuery} | ||
| onValueChange={setSearchQuery} | ||
| /> | ||
| </div> | ||
|
|
||
| <CommandList className="list custom-scrollbar"> | ||
| {isSearching && <div className="empty">Searching...</div>} | ||
|
|
||
| {isSearchEmpty && ( | ||
| <div className="empty">Type to search for coins...</div> | ||
| )} | ||
|
|
||
| {isTrendingListVisible && ( | ||
| <CommandGroup className="group"> | ||
| {trendingCoins.map(({ item }) => ( | ||
| <SearchItem | ||
| key={item.id} | ||
| coin={item} | ||
| onSelect={handleSelect} | ||
| isActiveName={false} | ||
| /> | ||
| ))} | ||
| </CommandGroup> | ||
| )} | ||
| {(searchError || isNoResults) && ( | ||
| <CommandEmpty> | ||
| {searchError | ||
| ? 'Failed to load results. Please try again.' | ||
| : 'No coins found.'} | ||
| </CommandEmpty> | ||
| )} | ||
|
|
||
| {isResultsVisible && ( | ||
| <CommandGroup | ||
| heading={<p className="heading">Search Results</p>} | ||
| className="group" | ||
| > | ||
| {searchResults.slice(0, SEARCH_LIMIT).map((coin) => ( | ||
| <SearchItem | ||
| key={coin.id} | ||
| coin={coin} | ||
| onSelect={handleSelect} | ||
| isActiveName | ||
| /> | ||
| ))} | ||
| </CommandGroup> | ||
| )} | ||
| </CommandList> | ||
| </CommandDialog> | ||
| </div> | ||
| ); | ||
| }; | ||
|
|
||
| export default SearchModal; | ||
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
📐 Maintainability & Code Quality | 🟡 Minor | ⚡ Quick win
Remove debug
console.logbefore merge.console.log(coinOHLCData)is a debug artifact that should not be shipped to production. It will log potentially large OHLC arrays to the server console on every coin page request.🧹 Proposed fix
- console.log(coinOHLCData);📝 Committable suggestion
🤖 Prompt for AI Agents