Fix: Protobuf output - #3151
Conversation
|
@mike-hunhoff Could you please review it? |
There was a problem hiding this comment.
A lot of code has been removed from this file. I'm not familiar with capa's protobuf support. @williballenthin @mr-tz are there specifc commands that @saniyafatima07 must use to generate these stub files? Or do these changes look correct?
There was a problem hiding this comment.
these should be auto-generated (and the header kept?!)
how did you generate these @saniyafatima07?
the changes to the .proto above look reasonable
do we have documentation on this?
There was a problem hiding this comment.
@mr-tz I generated it using this command:
protoc --python_out=. --pyi_out=. capa/render/proto/capa.proto
There was a problem hiding this comment.
do we have documentation on this?
Currently, we don’t have documentation for the protobuf output. I’ll add it once the issue is fixed.
There was a problem hiding this comment.
the header says:
@generated by mypy-protobuf. Do not edit manually! isort:skip_file
@williballenthin can you chime in here?
There was a problem hiding this comment.
this is probably a matter of which version of protoc is used. hopefully we have it documented somewhere.
in theory, it doesn't really matter which (compatible) version is used, but of course its nice when our diffs are nice and tight.
let me poke around and see what i can figure out.
Adds static analysis for script files (C#, Python, ASPX, HTML embedded scripts) using Tree-Sitter feature extractors. Revives and completes work originally introduced in mandiant#1080. Co-authored-by: Edoardo Allegrini <allegrini.1969146@studenti.uniroma1.it> Co-authored-by: Adam Storek <adamstorek@users.noreply.github.com>
d70db63 to
091b508
Compare
Adds static analysis for script files (C#, Python, ASPX, HTML embedded scripts) using Tree-Sitter feature extractors. Revives and completes work originally introduced in mandiant#1080.
acd318f to
5f7a0a5
Compare
10165af to
bffd0f3
Compare
4 participants
closes #3146
Checklist
The unit test was assisted by Chatgpt. All code was reviewed, modified and tested manually before submission.