fix: add IDA 8.5 compatibility - #3138
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
There was a problem hiding this comment.
Please add bug fixes, new features, breaking changes and anything else you think is worthwhile mentioning to the master (unreleased) section of CHANGELOG.md. If no CHANGELOG update is needed add the following to the PR description: [x] No CHANGELOG update needed
CHANGELOG updated or no update needed, thanks! 😄
As seen in the link below IDA 8.5 uses the same updated api a IDA 9 as such the compat comparison is wrong and lead to a failure on loading the plugin because idaapi.get_inf_structure() has been removed in that idaapi. https://docs.hex-rays.com/8.5/developer-guide/idapython/idapython-porting-guide-ida-9
c6ff4dc to
0ff1125
Compare
|
@williballenthin does this make sense? |
williballenthin
left a comment
williballenthin
left a comment
There was a problem hiding this comment.
assuming the author tested this locally, the changes make sense to me
|
@1337Name can you show this running appropriately with the updated code please? |
|
3 participants
This is just simple 1 line fix.
As seen in the link below IDA 8.5 uses the same (to my knowledge) updated api a IDA 9 as such the version comparison in capa/ida/helpers.py:59 mistakenly does not include ida 8.5 to the upgraded api. This lead to a failure on loading the plugin on ida 8.5 because idaapi.get_inf_structure() has been removed in that idaapi for both 8.5 and 9.x. but for ida 8.5 the path for the old api is taken.
The reason for this bug probably is that 8.5 was released after 9.0 so the helpers.py was never updated for the 8.5 release
Tested by loading the plugin with IDA 8.5.
REFERENCE
https://docs.hex-rays.com/8.5/developer-guide/idapython/idapython-porting-guide-ida-9#inf_structure-accessors
Checklist