Improve Quadrant computation robustness by using vector endpoints - #1226
Merged
Conversation
dr-jts
changed the title
cursor Bot
pushed a commit
to grootstebozewolf/jts
that referenced
this pull request
Aug 16, 2026
…cationtech#1226) Order outgoing halves by endpoint quadrant and orientation, not atan2 of subtracted direction vectors. Stamp TANGENT_LEAVE_ANGLE when that order ties, so distinct direction points do not collapse. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
cursor Bot
pushed a commit
to grootstebozewolf/jts
that referenced
this pull request
Aug 16, 2026
One short bullet per validated claim on feature/sfa-curve-rgr. D-HF from 0ca71b4, not #45. No Bar 2, no locationtech#1224/locationtech#1226. Co-authored-by: Jeroen Bloemscheer <grootstebozewolf@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When computing the quadrant of a vector it is more robust to use the vector endpoints directly, instead of computing the X and Y deltas (which requires FP arithmetic, not just comparisons). This PR switches to using that method where possible (which includes all uses in the JTS core).
See also #1224.