Skip to content

pyverbs: Update MW rkey after type 2 bind #1777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
zzwzds wants to merge 1 commit into
base: master
Choose a base branch
from
+19 −3
Open

pyverbs: Update MW rkey after type 2 bind #1777

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 15 additions & 1 deletion pyverbs/qp.pyx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,6 +32,19 @@ cdef extern from 'endian.h':
unsigned long htobe32(unsigned long host_32bits)


cdef void update_mw_rkeys(v.ibv_send_wr *wr, v.ibv_send_wr *bad_wr):
"""
Update MW rkeys for successfully posted bind WRs.

ibv_post_send() returns the first WR that was not posted in bad_wr, so
only the WRs preceding it were accepted when posting a list fails.
"""
while wr != bad_wr:
if wr.opcode == e.IBV_WR_BIND_MW:
wr.bind_mw.mw.rkey = wr.bind_mw.rkey
wr = wr.next


cdef class QPCap(PyverbsObject):
def __init__(self, max_send_wr=1, max_recv_wr=10, max_send_sge=1,
max_recv_sge=1, max_inline_data=0):
Expand Down Expand Up @@ -1262,8 +1275,9 @@ cdef class QP(PyverbsCM):
"""
# In order to provide a pointer to a pointer, use a temporary cdef'ed
# variable.
cdef v.ibv_send_wr *my_bad_wr
cdef v.ibv_send_wr *my_bad_wr = NULL
rc = v.ibv_post_send(self.qp, &wr.send_wr, &my_bad_wr)
update_mw_rkeys(&wr.send_wr, my_bad_wr)
if rc != 0:
if (bad_wr):
memcpy(&bad_wr.send_wr, my_bad_wr, sizeof(bad_wr.send_wr))
Expand Down
6 changes: 4 additions & 2 deletions tests/test_mr.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -317,9 +317,11 @@ def bind_mw_type_2(self):
# Poll the bind MW WR.
u.poll_cq(self.server.cq)
u.poll_cq(self.client.cq)
self.server.rkey = client_send_wr.rkey
self.assertEqual(self.client.mw.rkey, client_send_wr.rkey)
self.assertEqual(self.server.mw.rkey, server_send_wr.rkey)
self.server.rkey = self.client.mw.rkey
self.server.raddr = self.client.mr.buf
self.client.rkey = server_send_wr.rkey
self.client.rkey = self.server.mw.rkey
self.client.raddr = self.server.mr.buf

def invalidate_mw_type1(self):
Expand Down