Skip to content

aureport: fix AVC result column always showing "unset" #546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Cropi wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −10
Open

aureport: fix AVC result column always showing "unset" #546

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
22 changes: 12 additions & 10 deletions src/ausearch-parse.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2037,19 +2037,21 @@ static int parse_avc(const lnode *n, search_items *s)
term = n->message;
goto other_avc;
}
// Do not override syscall success if already set.
// Syscall pass/fail is the authoritative value.
if (event_success != S_UNSET && s->success == S_UNSET) {
*term = 0;
if (strstr(str, "denied")) {
// Always record the AVC verdict (denied/granted) from the record.
// Only propagate it to s->success when a success filter is active
// and s->success hasn't been set yet; syscall pass/fail is the
// authoritative value and must not be overwritten.
*term = 0;
if (strstr(str, "denied")) {
an.avc_result = AVC_DENIED;
if (event_success != S_UNSET && s->success == S_UNSET)
s->success = S_FAILED;
an.avc_result = AVC_DENIED;
} else {
} else {
an.avc_result = AVC_GRANTED;
if (event_success != S_UNSET && s->success == S_UNSET)
s->success = S_SUCCESS;
an.avc_result = AVC_GRANTED;
}
*term = '{';
}
*term = '{';

// Now get permission
str = term + 1;
Expand Down
Loading