feat: add dex chart - #3614
Open
CasLubbers wants to merge 7 commits into
Open
Conversation
CasLubbers
requested review from
Ani1357,
j-zimnowoda and
merll
as code owners
September 2, 2026 13:31
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
Dex’s generated config currently contains at least one invalid setting that can prevent Dex from starting and/or causes continuous Secret churn (and rollouts) when enabled.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
This PR introduces Dex as a new (currently disabled-by-default) APL “core app”, including a vendored Helm chart, APL values templates (Helmfile + Go templates), schema/defaults wiring, and an ADR describing the longer-term direction for using Dex as an OIDC issuer.
Changes:
- Add Dex Helm chart under
charts/dex/and register it incharts/dependencies.yaml. - Wire Dex into APL’s values pipeline (defaults, derived values, schema, Helmfile releases, fixtures) and add ExternalSecret-based configuration/secrets generation.
- Add an ADR documenting the Dex-as-issuer design rationale and tradeoffs.
File summaries
| File | Description |
|---|---|
| values/dex/dex.gotmpl | APL chart values template for Dex (image override, routing, RBAC, resources). |
| values/dex/dex-raw.gotmpl | Raw manifests for Dex (ServiceEntry + ExternalSecrets + generators). |
| values-schema.yaml | Adds apps.dex schema (enablement, replicas, resources, idp clientID, etc.). |
| tests/fixtures/env/apps/dex.yaml | Adds Dex app fixture values for template/values validation. |
| helmfile.d/snippets/dex-config.gotmpl | Dex config.yaml template rendered into an ExternalSecret-managed Secret. |
| helmfile.d/snippets/derived.gotmpl | Adds _derived.dexDomain for consistent domain computation. |
| helmfile.d/snippets/defaults.yaml | Adds Dex defaults under apps.dex (disabled by default). |
| helmfile.d/helmfile-05.init.yaml.gotmpl | Adds dex-artifacts (raw) and dex (chart) releases gated by apps.dex.enabled. |
| core.yaml | Adds the dex namespace to the platform namespaces list. |
| charts/dex/values.yaml | Vendored Dex chart default values. |
| charts/dex/templates/tests/no-config-secret.yaml | Helm test template for the “no config secret creation” scenario. |
| charts/dex/templates/servicemonitor.yaml | ServiceMonitor template (optional Prometheus scrape). |
| charts/dex/templates/serviceaccount.yaml | ServiceAccount template (optional). |
| charts/dex/templates/service.yaml | Service template (http/https/grpc/telemetry). |
| charts/dex/templates/secret.yaml | Config Secret template (when configSecret.create is true). |
| charts/dex/templates/rbac.yaml | RBAC templates for Dex CRDs/CRs access. |
| charts/dex/templates/poddisruptionbudget.yaml | PDB template (optional). |
| charts/dex/templates/NOTES.txt | Helm install notes for accessing Dex. |
| charts/dex/templates/networkpolicy.yaml | NetworkPolicy template (optional). |
| charts/dex/templates/ingress.yaml | Ingress template (optional). |
| charts/dex/templates/httproute.yaml | Gateway API HTTPRoute template (optional). |
| charts/dex/templates/hpa.yaml | HPA template (optional). |
| charts/dex/templates/deployment.yaml | Deployment template for Dex workload. |
| charts/dex/templates/_helpers.tpl | Chart helper templates (names/labels/namespace helpers). |
| charts/dex/README.md | Vendored chart README. |
| charts/dex/LICENSE | Vendored chart license. |
| charts/dex/Chart.yaml | Dex chart metadata. |
| charts/dex/.helmignore | Helm ignore patterns for the chart. |
| charts/dependencies.yaml | Registers Dex dependency (repo + version). |
| adr/2026-08-06-dex-as-issuer.md | Architectural decision record for Dex as issuer direction. |
Review details
- Files reviewed: 30/30 changed files
- Comments generated: 4
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
merll
approved these changes
Sep 3, 2026
Contributor
|
Comparison of Helm chart templating output: # New file added: dex-dex
# New file added: dex-dex-artifacts
# otomi-api/templates/core-config.yaml
@@ data.core.yaml @@
! ± value change in multiline text (one insert, no deletions)
adminApps:
- deps:
- prometheus
name: alertmanager
[536 lines unchanged)]
- app: grafana
name: grafana
- disableIstioInjection: true
name: istio-system
+ - app: dex
+ name: dex
- name: keycloak
- disableIstioInjection: true
name: apl-keycloak-operator
- app: knative
[66 lines unchanged)]
path: /explore?orgId=1&left=%7B"datasource":"loki","queries":%5B%7B"refId":"A","expr":"","queryType":"range","datasource":%7B"type":"loki","uid":"loki"%7D%7D%5D,"range":%7B"from":"now-1h","to":"now"%7D%7D
useHost: grafana
- name: tekton
ownHost: true
# otomi-api/templates/deployment.yaml
# rabbitmq-cluster-operator/templates/messaging-topology-operator/validating-webhook-configuration.yaml
# values-repo.yaml
@@ apps @@
! + one map entry added:
+ dex:
+ resources:
+ limits:
+ cpu: 200m
+ memory: 128Mi
+ requests:
+ cpu: 20m
+ memory: 64Mi
+ _rawValues: {}
+ enabled: true
+ replicas: 1
+ idp:
+ clientID: otomi
|
CasLubbers
force-pushed
the
APL-2074
branch
2 times, most recently
from
September 8, 2026 14:18
1f047b8 to
13bc904
Compare
j-zimnowoda
reviewed
Sep 9, 2026
j-zimnowoda
reviewed
Sep 9, 2026
CasLubbers
force-pushed
the
APL-2074
branch
2 times, most recently
from
September 11, 2026 09:24
1896078 to
6562c3b
Compare
CasLubbers
force-pushed
the
APL-2074
branch
from
September 11, 2026 11:37
5662c94 to
b370383
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌 Summary
🔍 Reviewer Notes
🧹 Checklist
Stack created with GitHub Stacks CLI • Give Feedback 💬