Skip to content

Handle BCS serialization failure gracefully in the bridge burn monitor #6584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
ma2bd wants to merge 1 commit into from
+10 −1
Closed

Handle BCS serialization failure gracefully in the bridge burn monitor #6584

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion linera-bridge/src/monitor/linera.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,7 +375,16 @@ async fn persist_cert_bytes(
event_indices: &[u32],
cert: &ConfirmedBlockCertificate,
) {
let cert_bytes = bcs::to_bytes(cert).expect("BCS-serialize cert");
// BCS serialization can fail (e.g. for overly nested or oversized values), so skip the height
// rather than panicking and aborting the whole monitor loop — matching how the caller handles a
// failed certificate read.
let cert_bytes = match bcs::to_bytes(cert) {
Ok(bytes) => bytes,
Err(error) => {
tracing::warn!(?height, ?error, "Failed to BCS-serialize certificate");
return;
}
};
let state = monitor.read().await;
let Some(db) = state.db() else { return };
for event_index in event_indices {
Expand Down
Loading