Anchor multi-leader jitter target to the current round's start.#6490
Closed
afck wants to merge 1 commit into
Closed
Anchor multi-leader jitter target to the current round's start.#6490afck wants to merge 1 commit into
afck wants to merge 1 commit into
Conversation
The jitter delay used `now` as the round-start anchor whenever the proposed round differed from `manager.current_round` (the conflict-bump case) or `manager.round_timeout` was missing. On a busy chain where `process_inbox` interrupts repeatedly, `propose_at = now + delay` was recomputed each retry and the target receded by `delay` every time, so a non-preferred client never reached it and never proposed. Derive the anchor instead from data the chain manager already tracks: `manager.round_timeout - ownership.round_timeout(current_round)`. If either is `None`, propose immediately rather than wait against a stale anchor.
Contributor
Author
|
Closing in favor of #6455. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The jitter delay used
nowas the round-start anchor whenever the proposed round differed frommanager.current_round(the conflict-bump case) ormanager.round_timeoutwas missing. On a busy chain whereprocess_inboxinterrupts repeatedly,propose_at = now + delaywas recomputed each retry and the target receded bydelayevery time, so a non-preferred client never reached it and never proposed.Proposal
Derive the anchor instead from data the chain manager already tracks:
manager.round_timeout - ownership.round_timeout(current_round). If either isNone, propose immediately rather than wait against a stale anchor.Test Plan
A regression test was added.
Release Plan
testnet_conway.Links