Skip to content

[testnet] CI: pin cargo-rdme to 1.5.0 to fix readme lint on the pinned toolchain#6489

Merged
ndr-ds merged 1 commit into
testnet_conwayfrom
ndr-ds/pin-cargo-rdme-conway
Jun 12, 2026
Merged

[testnet] CI: pin cargo-rdme to 1.5.0 to fix readme lint on the pinned toolchain#6489
ndr-ds merged 1 commit into
testnet_conwayfrom
ndr-ds/pin-cargo-rdme-conway

Conversation

@ndr-ds

@ndr-ds ndr-ds commented Jun 12, 2026

Copy link
Copy Markdown
Contributor

Motivation

The lint-check-for-outdated-readme job is now failing deterministically on every testnet_conway PR. cargo install cargo-rdme --locked resolves to the freshly released cargo-rdme 1.5.1, whose lockfile pulls zmij 1.0.21, which uses hint::select_unpredictable — stabilized in Rust 1.88. This branch's pinned toolchains (stable 1.86.0, nightly-2025-04-03) cannot build it, so the install step exits 101 before the README check even runs. The same job passed on this branch as recently as 2026-06-11 (PRs #6474, #6476) and broke on 2026-06-12 (#6488), bracketing the upstream release. main is unaffected (toolchain 1.95).

Proposal

Pin the tool: cargo install cargo-rdme --locked --version 1.5.0, with a comment explaining why. cargo-rdme 1.5.0 declares rust-version = 1.86.0.

Test Plan

Verified locally that cargo install cargo-rdme --locked --version 1.5.0 builds successfully on rustc 1.86.0 (this branch's stable pin) and the binary runs. This PR's own lint-check-for-outdated-readme job exercises the pinned install directly, so its CI result is the end-to-end proof.

Release Plan

  • CI-only change on testnet_conway; nothing to deploy. main does not need this (newer toolchain), though the pin could be ported there for reproducibility if desired.

@ndr-ds ndr-ds marked this pull request as ready for review June 12, 2026 13:38
@ndr-ds

ndr-ds commented Jun 12, 2026

Copy link
Copy Markdown
Contributor Author

Merging to make CI green again

@ndr-ds ndr-ds merged commit e720f17 into testnet_conway Jun 12, 2026
28 checks passed
@ndr-ds ndr-ds deleted the ndr-ds/pin-cargo-rdme-conway branch June 12, 2026 13:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant