[testnet] CI: pin cargo-rdme to 1.5.0 to fix readme lint on the pinned toolchain#6489
Merged
Merged
Conversation
Contributor
Author
|
Merging to make CI green again |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
The
lint-check-for-outdated-readmejob is now failing deterministically on everytestnet_conwayPR.cargo install cargo-rdme --lockedresolves to the freshly released cargo-rdme 1.5.1, whose lockfile pullszmij 1.0.21, which useshint::select_unpredictable— stabilized in Rust 1.88. This branch's pinned toolchains (stable 1.86.0, nightly-2025-04-03) cannot build it, so the install step exits 101 before the README check even runs. The same job passed on this branch as recently as 2026-06-11 (PRs #6474, #6476) and broke on 2026-06-12 (#6488), bracketing the upstream release.mainis unaffected (toolchain 1.95).Proposal
Pin the tool:
cargo install cargo-rdme --locked --version 1.5.0, with a comment explaining why. cargo-rdme 1.5.0 declaresrust-version = 1.86.0.Test Plan
Verified locally that
cargo install cargo-rdme --locked --version 1.5.0builds successfully on rustc 1.86.0 (this branch's stable pin) and the binary runs. This PR's ownlint-check-for-outdated-readmejob exercises the pinned install directly, so its CI result is the end-to-end proof.Release Plan
testnet_conway; nothing to deploy.maindoes not need this (newer toolchain), though the pin could be ported there for reproducibility if desired.