Add LINE Seed Sans font family#11
Draft
halken wants to merge 2 commits into
Draft
Conversation
Add the LINE Seed Sans (Latin) family with five weights — Thin, Regular, Bold, ExtraBold and Heavy — following the existing LINE Seed JP setup. - Add LINESeedSans/sources with the .glyphspackage sources, config.yaml and METADATA.pb - Register the family in the Makefile (build/test/proof) and add LINESeedSans/fonts to the CI build artifact - Normalize weight classes to the Google Fonts standard (Thin=100, Regular=400) - Set fsType to 0 (installable), enable USE_TYPO_METRICS and harmonize vertical metrics (typo == hhea, lineGap = 0) - Ignore generated build files under LINESeedSans/sources Known remaining item: the fonts do not yet cover the full GF Latin Core glyph set (glyph_coverage) and this must be resolved before submission to Google Fonts. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
The build job only uploads the github-pages artifact on the main branch (upload-pages-artifact is guarded with `if: github.ref == 'refs/heads/main'`), but the deploy job ran unconditionally. On PR branches the deploy job tried to deploy a non-existent artifact and failed. Add the same main-branch guard to the deploy job so it is skipped on non-main branches. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Add the LINE Seed Sans (Latin) family with five weights — Thin, Regular, Bold, ExtraBold and Heavy — following the existing LINE Seed JP setup.
Changes
LINESeedSans/sourceswith the.glyphspackagesources,config.yamlandMETADATA.pbMakefile(build/test/proof) and addLINESeedSans/fontsto the CI build artifactfsTypeto 0 (installable), enableUSE_TYPO_METRICSand harmonize vertical metrics (typo == hhea, lineGap = 0)LINESeedSans/sourcesLocal verification
make build/make proofsucceed; ttf/otf/woff2 generated for all 5 weights, names and usWeightClass correct.make test(Fontspector, googlefonts profile): the Sans-specific metric/embedding FAILs (fstype,use_typo_metrics,vertical_metrics,os2_metrics_match_hhea) are resolved. Remaining FAILs are either shared with LINE Seed JP (known / agreed with the GF team) or theglyph_coverageitem below.Known remaining item (draft)
The fonts do not yet cover the full GF Latin Core glyph set (
glyph_coverage: 202 codepoints missing — accented Latin letters and diacritics). This must be resolved before submission to Google Fonts. Kept as a draft until the glyph coverage is addressed.