Skip to content

swapserverrpc: add multi-address proofs#1180

Open
hieblmi wants to merge 1 commit into
lightninglabs:masterfrom
hieblmi:multi-address-proto
Open

swapserverrpc: add multi-address proofs#1180
hieblmi wants to merge 1 commit into
lightninglabs:masterfrom
hieblmi:multi-address-proto

Conversation

@hieblmi

@hieblmi hieblmi commented Jul 21, 2026

Copy link
Copy Markdown
Collaborator

Carry each deposit client derivation key and an optional generated change descriptor in static-address loop-in and withdrawal requests. The server can use these fields to validate scripts it does not store directly.

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request updates the RPC definitions to enhance security and flexibility for static-address loop-in and withdrawal operations. By adding client public key mappings and change output metadata, the server gains the ability to verify deposit derivations and handle change outputs more effectively.

Highlights

  • Added multi-address proof support: Introduced deposit_to_client_pubkeys maps to ServerPsbtWithdrawRequest and ServerStaticAddressLoopInRequest to allow the server to validate scripts it does not store directly.
  • Added change output metadata: Defined a new StaticAddressChangeOutput message and integrated it into withdrawal and loop-in requests to support returning funds to newly generated static addresses.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the swapserverrpc protocol definitions to support static address change outputs and client public keys. It introduces a new StaticAddressChangeOutput message and adds deposit_to_client_pubkeys and change_output fields to both ServerPsbtWithdrawRequest and ServerStaticAddressLoopInRequest messages. I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@hieblmi
hieblmi requested a review from starius July 21, 2026 11:26
@hieblmi hieblmi self-assigned this Jul 21, 2026
@hieblmi
hieblmi force-pushed the multi-address-proto branch 4 times, most recently from 09b34a2 to 76b3b01 Compare July 23, 2026 14:39
Carry each deposit client derivation key and an optional generated
change descriptor in static-address loop-in and withdrawal requests. The
server can use these fields to validate scripts it does not store
directly.
@hieblmi
hieblmi force-pushed the multi-address-proto branch from 76b3b01 to 0e8b671 Compare July 23, 2026 14:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants