Skip to content

Rework ChannelManager::funding_transaction_signed - #4336

Merged
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
wpaulino:funding-transaction-signed-rework
Jan 30, 2026
Merged

Rework ChannelManager::funding_transaction_signed#4336
TheBlueMatt merged 3 commits into
lightningdevkit:mainfrom
wpaulino:funding-transaction-signed-rework

Support funding_transaction_signed for unfunded dual-funded channels

be67c67
Select commit
Loading
Failed to load commit list.
Codecov / codecov/project succeeded Jan 29, 2026 in 0s

86.07% (-0.47%) compared to 8cdc86a

View this Pull Request on Codecov

86.07% (-0.47%) compared to 8cdc86a

Details

Codecov Report

❌ Patch coverage is 72.00957% with 117 lines in your changes missing coverage. Please review.
✅ Project coverage is 86.07%. Comparing base (8cdc86a) to head (be67c67).
⚠️ Report is 33 commits behind head on main.

Files with missing lines Patch % Lines
lightning/src/ln/channel.rs 72.72% 54 Missing and 6 partials ⚠️
lightning/src/ln/channelmanager.rs 71.42% 46 Missing and 10 partials ⚠️
lightning/src/ln/interactivetxs.rs 50.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4336      +/-   ##
==========================================
- Coverage   86.53%   86.07%   -0.47%     
==========================================
  Files         158      156       -2     
  Lines      103190   102804     -386     
  Branches   103190   102804     -386     
==========================================
- Hits        89300    88490     -810     
- Misses      11469    11803     +334     
- Partials     2421     2511      +90     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.