Skip to content

Upgrade channel type when splicing #1340

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
t-bast wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Upgrade channel type when splicing #1340

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 20 additions & 0 deletions 02-peer-protocol.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1657,6 +1657,9 @@ to indicate that one of the splice transactions reached acceptable depth.

1. `tlv_stream`: `splice_init_tlvs`
2. types:
1. type: 1 (`channel_type`)
2. data:
* [`...*byte`:`type`]
1. type: 2 (`require_confirmed_inputs`)

`funding_contribution_satoshis` is the amount the sender is adding to their
Expand All @@ -1681,6 +1684,8 @@ The sending node:
the amount that will be added to its current channel balance.
- If it requires the receiving node to only use confirmed inputs:
- MUST set `require_confirmed_inputs`.
- If it wants to change the `channel_type` of the channel:
- MUST set `channel_type` to the `channel_type` it wants to use.
- SHOULD use a different `funding_pubkey` than the one used for the
previous funding transaction.

Expand All @@ -1702,6 +1707,8 @@ The receiving node:
and fail the channel.
- If the `funding_feerate_perkw` is unacceptable:
- MUST respond with `tx_abort`.
- If it doesn't want to update the channel to the provided `channel_type`:
- MUST respond with `tx_abort`.
- If `funding_contribution_satoshis` is negative and its absolute value is
greater than the sending node's current channel balance:
- MUST send a `warning` and close the connection or send an `error`
Expand All @@ -1722,6 +1729,9 @@ The receiving node:

1. `tlv_stream`: `splice_ack_tlvs`
2. types:
1. type: 1 (`channel_type`)
2. data:
* [`...*byte`:`type`]
1. type: 2 (`require_confirmed_inputs`)

#### Requirements
Expand All @@ -1733,13 +1743,21 @@ The sending node:
to contribute to the splice.
- If it requires the receiving node to only use confirmed inputs:
- MUST set `require_confirmed_inputs`.
- If `channel_type` was set in `splice_init`:
- MUST set `channel_type` to the `channel_type` from `splice_init`.

The receiving node:
- If it has sent `splice_init`:
- If `funding_contribution_satoshis` is negative and its absolute value is
greater than the sending node's current channel balance:
- MUST send a `warning` and close the connection or send an `error`
and fail the channel.
- If `channel_type` is set but `channel_type` was not set in `splice_init`:
- MUST send a `warning` and close the connection or send an `error`
and fail the channel.
- If `channel_type` does not match the `channel_type` from `splice_init`:
- MUST send a `warning` and close the connection or send an `error`
and fail the channel.
- If it accepts the splice attempt:
- MUST start an `interactive-tx` session to create the splice transaction.
- Otherwise:
Expand Down Expand Up @@ -1845,6 +1863,8 @@ The sending node:
to the main balance of their respective sender.
- Uses the same feerate as the existing commitment transaction.
- Uses the same `commitment_number` as the existing commitment transaction.
- If `channel_type` was set in `splice_init` and `splice_ack`:
- MUST use that `channel_type` instead of the previous `channel_type`.
- MUST send signatures for pending HTLCs.
- MUST remember the details of this splice transaction.

Expand Down