feat: add automated tagging and pushing of new releases#579
Closed
bennetgallein wants to merge 1 commit into
Closed
feat: add automated tagging and pushing of new releases#579bennetgallein wants to merge 1 commit into
bennetgallein wants to merge 1 commit into
Conversation
Member
|
Thanks for working on this, but don't think we want to automate publishing Docker release tags directly from upstream version bumps. An upstream LibreNMS release being available is not enough signal that the Docker image is ready to publish. We need to build and test the image first so we can catch upstream regressions or image-specific breakage before pushing a versioned tag. This is the same release policy noted in #209. A future staging/testing flow could be discussed separately, but this PR bypasses that gate by creating releases from |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding release process automation.
When master is pushed, release.yml determines the correct version to build (takes LIBRENMS_VERSION from Dockerfile), updated by renovate-bot via PR. Uses the historical commits to determine if an increase in revision (-r1) is required and falls back to "-r0" (this is a change, but technically the initial release wouldn't be a revision IMO. It then uses workflow_dispatch to trigger the usual build-workflow for the new tag (since tags pushed by bot would not trigger a workflow).