Skip to content

chore(Data/List/MinMax): use to_dual#41559

Open
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-List.max
Open

chore(Data/List/MinMax): use to_dual#41559
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-List.max

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR uses to_dual to translate some theorems about maxima and minima on lists.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary 0362598d75

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

- Perm.minimum_eq
- argmin
- argmin_concat
- argmin_cons
- argmin_eq_none
- argmin_eq_some_iff
- argmin_mem
- argmin_nil
- argmin_singleton
- coe_minimum_of_length_pos
- foldr_min_of_ne_nil
- getD_min?_eq_untopD_minimum
- index_of_argmin
- le_min_of_forall_le
- le_minimum_of_forall_le
- le_of_mem_argmin
- mem_argmin_iff
- min_le_of_le
- min_le_of_le'
- minimum
- minimum_anti
- minimum_append
- minimum_concat
- minimum_cons
- minimum_eq_coe_iff
- minimum_eq_top
- minimum_le_coe_iff
- minimum_le_of_mem
- minimum_le_of_mem'
- minimum_mem
- minimum_ne_top_of_length_pos
- minimum_ne_top_of_ne_nil
- minimum_nil
- minimum_of_length_pos
- minimum_of_length_pos_le_getElem
- minimum_of_length_pos_le_iff
- minimum_of_length_pos_le_of_mem
- minimum_of_length_pos_mem
- minimum_singleton
- not_lt_minimum_of_mem
- not_lt_minimum_of_mem'
- not_lt_of_mem_argmin

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 0362598).

  • +2 new declarations
  • −2 removed declarations
-List.le_min_of_forall_le
+List.le_min_of_le
+List.min_le_of_forall_le
-List.min_le_of_le

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 0362598d75
Reference commit 8bba420098

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant