Skip to content

chore(order/ConditionallyCompleteLattice): use to_dual more#41558

Open
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-ConditionallyCompleteLattice
Open

chore(order/ConditionallyCompleteLattice): use to_dual more#41558
JovanGerb wants to merge 1 commit into
leanprover-community:masterfrom
JovanGerb:Jovan-to_dual-ConditionallyCompleteLattice

Conversation

@JovanGerb

Copy link
Copy Markdown
Contributor

This PR uses to_dual in most remaining places in Mathlib.Order.ConditionallyCompleteLattice.Basic.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 10, 2026

Copy link
Copy Markdown

PR summary 078816d181

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

+ coe_sSup'
+ instInfSet
+ instance [SupSet α] : SupSet (WithTop α)
+ sInf_empty
+ sInf_eq
+ sInf_of_not_bddBelow
+ sInf_singleton_top
+ sSup_empty
+ sSup_eq
+ sSup_of_not_bddAbove
+ sSup_of_top_mem
+ sSup_singleton_top
- AntitoneOn.sSup_image_Icc
- MonotoneOn.csSup_eq_of_subset_of_forall_exists_le
- MonotoneOn.sSup_image_Icc
- WithBot.WithTop.completeLattice
- WithBot.sSup_empty
- WithTop.coe_sSup'
- WithTop.instInfSet
- WithTop.instSupSet
- WithTop.sInf_empty
- WithTop.sInf_eq
- WithTop.sInf_of_not_bddBelow
- WithTop.sInf_singleton_top
- WithTop.sSup_empty
- WithTop.sSup_eq
- WithTop.sSup_of_not_bddAbove
- WithTop.sSup_of_top_mem
- WithTop.sSup_singleton_top
- bddBelow_Icc
- bddBelow_Ico
- bddBelow_Ioc
- bddBelow_Ioo
- ciInf_eq_univ_of_not_bddBelow
- ciInf_of_not_bddBelow
- csInf_Ioc
- csInf_Ioi
- csInf_Ioo
- csInf_eq_bot_of_bot_mem
- csInf_eq_csInf_of_forall_exists_le
- csInf_eq_of_forall_ge_of_forall_gt_exists_lt
- csInf_eq_univ_of_not_bddBelow
- csInf_image2_eq_csInf_csInf
- csInf_image2_eq_csInf_csSup
- csInf_image2_eq_csSup_csInf
- csInf_image2_eq_csSup_csSup
- csInf_insert
- csInf_le_csInf
- csInf_le_iff
- csInf_lt_iff
- csInf_lt_of_lt
- csInf_of_not_bddBelow
- csInf_pair
- csInf_union
- csInf_upperBounds_eq_csSup
- csInf_upperBounds_range
- exists_lt_of_csInf_lt
- instance [CompleteLattice α] : CompleteLattice (WithBot α)
- isGLB_Icc
- isGLB_Ico
- isLUB_Ico
- isLUB_Ioo
- isLeast_Icc
- isLeast_Ico
- le_csInf_iff
- le_csInf_inter
- lowerBounds_Icc
- lowerBounds_Ico
- map_csInf_le_csInf_image
- notMem_of_csSup_lt
- sInf_iUnion_Ici
- upperBounds_Ico
- upperBounds_Ioo

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 078816d).

  • +1 new declarations
  • −0 removed declarations
+le_csInf_union

No changes to strong technical debt.

No changes to weak technical debt.

Current commit 078816d181
Reference commit 8bba420098

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant