Skip to content

chore: remove noncomputable section when only theorems in file#41554

Open
felixpernegger wants to merge 2 commits into
leanprover-community:masterfrom
felixpernegger:emptynoncomputablesection
Open

chore: remove noncomputable section when only theorems in file#41554
felixpernegger wants to merge 2 commits into
leanprover-community:masterfrom
felixpernegger:emptynoncomputablesection

Conversation

@felixpernegger

@felixpernegger felixpernegger commented Jul 9, 2026

Copy link
Copy Markdown
Contributor

Removes noncomputable section whenever no def/abbrev/instances appear in the section.
This is not the most important change, but prepares for a more general cleanup around noncomputable.


Open in Gitpod

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR summary 888989df39

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff (regex)

No declarations were harmed in the making of this PR! 🐙

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean -- unavailable)

⚠️ The Mathlib cache for this PR's merge-base isn't on the server (typically a bors-batch intermediate that CI never built). Merge master into this PR and push to refresh.


No changes to strong technical debt.

No changes to weak technical debt.

Current commit 888989df39
Reference commit e3b73828b0

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

@felixpernegger felixpernegger changed the title chore: remove noncomputable section when only theorems iin file chore: remove noncomputable section when only theorems in file Jul 9, 2026
@felixpernegger

Copy link
Copy Markdown
Contributor Author

!bench

@leanprover-radar

leanprover-radar commented Jul 9, 2026

Copy link
Copy Markdown

Benchmark results for 888989d against e3b7382 are in. No significant results found. @felixpernegger

  • build//instructions: -15.2G (-0.01%)

No significant changes detected.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants