chore: prefer classical over open scoped Classical in proofs#41541
Open
felixpernegger wants to merge 1 commit into
Open
chore: prefer classical over open scoped Classical in proofs#41541felixpernegger wants to merge 1 commit into
classical over open scoped Classical in proofs#41541felixpernegger wants to merge 1 commit into
Conversation
Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
PR summary 1d4cde4641Import changes for modified filesNo significant changes to the import graph Import changes for all files
|
Contributor
Author
|
!bench |
|
Benchmark results for 1d4cde4 against 2d00c92 are in. No significant results found. @felixpernegger
No significant changes detected. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In #41423 it came up that it is preferable to use
classicalin proofs instead ofopen (scoped) Classical, as its slightly easier to maintain. This PR replaces all such occurences where it can be reasonably done.This is likely my last PR about this topic.
(I used Claude to fix some git issue, which is why it shows up in the commit)