Skip to content

feat(Algebra/Quaternion): quaternion are central simple#41538

Open
Mathias-Stout wants to merge 1 commit into
leanprover-community:masterfrom
justus-springer:justus/quaternion
Open

feat(Algebra/Quaternion): quaternion are central simple#41538
Mathias-Stout wants to merge 1 commit into
leanprover-community:masterfrom
justus-springer:justus/quaternion

Conversation

@Mathias-Stout

Copy link
Copy Markdown

We show that the quaternion algebra ℍ[R,a,b,c] over a field R is a central simple R-algebra, provided that c * (b ^ 2 + 4 * a) ≠ 0.

Co-authored-by: Justus Springer justusspringer@gmx.de


Open in Gitpod

@github-actions github-actions Bot added the new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community! label Jul 9, 2026
@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

Welcome new contributor!

Thank you for contributing to Mathlib! If you haven't done so already, please review our contribution guidelines, as well as the style guide and naming conventions. In particular, we kindly remind contributors that we have guidelines regarding the use of AI when making pull requests.

We use a review queue to manage reviews. If your PR does not appear there, it is probably because it is not successfully building (i.e., it doesn't have a green checkmark), has the awaiting-author tag, or another reason described in the Lifecycle of a PR. The review dashboard has a dedicated webpage which shows whether your PR is on the review queue, and (if not), why.

If you haven't already done so, please come to https://leanprover.zulipchat.com/, introduce yourself, and mention your new PR.

Thank you again for joining our community.

@github-actions

github-actions Bot commented Jul 9, 2026

Copy link
Copy Markdown

PR summary 86493005d2

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference
Mathlib.Algebra.QuaternionBasis -1346
Mathlib.Algebra.Quaternion -1330
Mathlib.Algebra.Quaternion.Basic 1330
Mathlib.Algebra.Quaternion.Basis 1346
Mathlib.Algebra.Quaternion.CentralSimple (new file) 1347

Declarations diff (regex)

+ eq_top_of_isUnit_mem
+ eq_top_of_mem_imJ_imK
+ eq_top_of_mem_re
+ exists_mem_ne_zero_of_ne_bot
+ isCentral
+ isSimpleRing
+ isUnit_iff
+ isUnit_of_isUnit_re
+ ne_bot_iff

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.

Declarations diff (Lean)

Lean-aware diff — post-build, computed from the Lean environment (commit 8649300).

  • +7 new declarations
  • −0 removed declarations
+QuaternionAlgebra.isCentral
+QuaternionAlgebra.isSimpleRing
+QuaternionAlgebra.isUnit_iff
+QuaternionAlgebra.isUnit_of_isUnit_re
+TwoSidedIdeal.eq_top_of_isUnit_mem
+TwoSidedIdeal.exists_mem_ne_zero_of_ne_bot
+TwoSidedIdeal.ne_bot_iff

No changes to strong technical debt.

Increase in weak tech debt: (relative, absolute) = (1.00, 0.00)
Current number Change Type (weak)
5005 1 exposed public sections

Current commit 86493005d2
Reference commit 2d00c9242a

This script lives in the mathlib-ci repository. To run it locally, from your mathlib4 directory:

git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci
../mathlib-ci/scripts/reporting/technical-debt-metrics.sh pr_summary
  • The relative value is the weighted sum of the differences with weight given by the inverse of the current value of the statistic.
  • The absolute value is the relative value divided by the total sum of the inverses of the current values (i.e. the weighted average of the differences).

note: file Mathlib/Algebra/QuaternionBasis.lean` was renamed to `Mathlib/Algebra/Quaternion/Basis.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

note: file Mathlib/Algebra/Quaternion.lean` was renamed to `Mathlib/Algebra/Quaternion/Basic.lean without a module deprecation
Please create a follow-up pull request adding one. Thanks!

@github-actions github-actions Bot added the file-removed A Lean module was (re)moved without a `deprecated_module` annotation label Jul 9, 2026
@mathlib-dependent-issues mathlib-dependent-issues Bot added the blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) label Jul 9, 2026
@mathlib-dependent-issues

Copy link
Copy Markdown

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

blocked-by-other-PR This PR depends on another PR (this label is automatically managed by a bot) file-removed A Lean module was (re)moved without a `deprecated_module` annotation new-contributor This PR was made by a contributor with at most 5 merged PRs. Welcome to the community!

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants