Skip to content

feat(ConditionallyCompleteLattice/Indexed): add binary versions of lemmas#38906

Open
lua-vr wants to merge 6 commits into
leanprover-community:masterfrom
lua-vr:indexed
Open

feat(ConditionallyCompleteLattice/Indexed): add binary versions of lemmas#38906
lua-vr wants to merge 6 commits into
leanprover-community:masterfrom
lua-vr:indexed

Conversation

@lua-vr

@lua-vr lua-vr commented May 4, 2026

Copy link
Copy Markdown
Contributor

Add binary versions of some of the lemmas. Those are useful when the domain is indexed over the members of a set.

From the Carleson project.


Open in Gitpod

@github-actions github-actions Bot added the t-order Order theory label May 4, 2026
@github-actions

github-actions Bot commented May 4, 2026

Copy link
Copy Markdown

PR summary 8eb1ca9e64

Import changes for modified files

No significant changes to the import graph

Import changes for all files
Files Import difference

Declarations diff

+ ciSup₂_le
+ ciSup₂_le'
+ exists_lt_of_lt_ciSup₂
+ exists_lt_of_lt_ciSup₂'
- le_ciInf

You can run this locally as follows
## from your `mathlib4` directory:
git clone https://github.com/leanprover-community/mathlib-ci.git ../mathlib-ci

## summary with just the declaration names:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh <optional_commit>

## more verbose report:
../mathlib-ci/scripts/pr_summary/declarations_diff.sh long <optional_commit>

The doc-module for scripts/pr_summary/declarations_diff.sh in the mathlib-ci repository contains some details about this script.


No changes to strong technical debt.
No changes to weak technical debt.

@grunweg grunweg added the carleson part of the ongoing formalization of Carleson's theorem label May 4, 2026
@grunweg grunweg changed the title feat(ConditionallyCompleteLattice/Indexed): add arity-two versions of lemmas feat(ConditionallyCompleteLattice/Indexed): add binary versions of lemmas May 4, 2026

@grunweg grunweg left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor comments.

Comment thread Mathlib/Order/ConditionallyCompleteLattice/Indexed.lean Outdated
Comment thread Mathlib/Order/ConditionallyCompleteLattice/Indexed.lean Outdated
Comment thread Mathlib/Order/ConditionallyCompleteLattice/Indexed.lean Outdated
Comment thread Mathlib/Order/ConditionallyCompleteLattice/Indexed.lean Outdated
Comment thread Mathlib/Order/ConditionallyCompleteLattice/Indexed.lean Outdated
@grunweg grunweg added the awaiting-author A reviewer has asked the author a question or requested changes. label May 4, 2026
@lua-vr

lua-vr commented May 4, 2026

Copy link
Copy Markdown
Contributor Author

-awaiting-author

@github-actions github-actions Bot removed the awaiting-author A reviewer has asked the author a question or requested changes. label May 4, 2026

@SnirBroshi SnirBroshi left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

Comment thread Mathlib/Order/ConditionallyCompleteLattice/Indexed.lean Outdated
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 11, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 13, 2026
@mathlib-merge-conflicts mathlib-merge-conflicts Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 15, 2026
@mathlib-merge-conflicts

Copy link
Copy Markdown

This pull request has conflicts, please merge master and resolve them.

@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 18, 2026
@lua-vr lua-vr force-pushed the indexed branch 2 times, most recently from e6f56e2 to cfd711c Compare May 18, 2026 12:51
@github-actions github-actions Bot added the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 18, 2026
@github-actions github-actions Bot removed the merge-conflict The PR has a merge conflict with master, and needs manual merging. (this label is managed by a bot) label May 18, 2026
Comment thread Mathlib/Order/ConditionallyCompleteLattice/Indexed.lean Outdated
theorem ciSup_le' {f : ι → α} {a : α} (h : ∀ i, f i ≤ a) : ⨆ i, f i ≤ a :=
csSup_le' <| forall_mem_range.2 h

theorem ciSup₂_le' {f : ∀ i, κ i → α} (h : ∀ i j, f i j ≤ a) : ⨆ (i) (j), f i j ≤ a :=

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please also add the dual of the theorem. Otherwise it will be more annoying when we do tag the whole file with to_dual.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sadly ConditionallyCompleteLinearOrderBot has no dual, so none of the theorems around here can be to_dualized

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah that's too bad, in that case ignore my comment.

@lua-vr lua-vr May 19, 2026

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@JovanGerb in #38938 I made an attempt to tag the whole file with to_dual (but this section was not included)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

carleson part of the ongoing formalization of Carleson's theorem t-order Order theory

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants