Skip to content

fix: preserve RTree row id semantics#7666

Open
ddupg wants to merge 1 commit into
lance-format:mainfrom
ddupg:codex/ddu-272-rtree-row-id
Open

fix: preserve RTree row id semantics#7666
ddupg wants to merge 1 commit into
lance-format:mainfrom
ddupg:codex/ddu-272-rtree-row-id

Conversation

@ddupg

@ddupg ddupg commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • keep RTree scalar index payloads interpreted as logical row ids
  • reject fragment coverage recalculation from RTree row-id payloads instead of deriving fragments from physical row addresses
  • cover stable-row-id multi-fragment RTree SQL scans where _rowid differs from _rowaddr

Testing

  • cargo fmt --all
  • cargo test -p lance test_geo_rtree_index
  • cargo test -p lance-index --features geo scalar::rtree::tests
  • git diff --check

@github-actions github-actions Bot added A-index Vector index, linalg, tokenizer bug Something isn't working labels Jul 7, 2026
@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 94.73684% with 2 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
rust/lance-index/src/scalar/rtree.rs 94.73% 1 Missing and 1 partial ⚠️

📢 Thoughts on this report? Let us know!

@ddupg ddupg force-pushed the codex/ddu-272-rtree-row-id branch from 2b072bd to 27bfc21 Compare July 7, 2026 11:54
@ddupg ddupg force-pushed the codex/ddu-272-rtree-row-id branch from 27bfc21 to f4972ab Compare July 7, 2026 11:58
@ddupg ddupg marked this pull request as ready for review July 7, 2026 13:03
@ddupg

ddupg commented Jul 8, 2026

Copy link
Copy Markdown
Contributor Author

@Xuanwo Could you help review this? thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-index Vector index, linalg, tokenizer bug Something isn't working

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant