feat(python): expose MemWAL shard delete#7649
Merged
Merged
Conversation
084bce9 to
4f00405
Compare
4f00405 to
979ac02
Compare
hamersaw
approved these changes
Jul 8, 2026
hamersaw
left a comment
Contributor
There was a problem hiding this comment.
This looks great! Thanks for the PR.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ShardWriter.delete(keys, *, schema=None)in the Python wrapper and PyO3 layer.RecordBatchconversion path for bothputanddelete.Tests
cargo fmt --alluv run make formatuv run pytest python/tests/test_mem_wal.py -quv run make lint(pyright reported 0 errors and 7 missing-type-stub warnings)CARGO_BUILD_JOBS=8 cargo clippy --all --tests --benches -- -D warnings