Skip to content

feat(python): expose MemWAL shard delete#7649

Merged
hamersaw merged 1 commit into
lance-format:mainfrom
u70b3:feat/python-mem-wal-delete
Jul 8, 2026
Merged

feat(python): expose MemWAL shard delete#7649
hamersaw merged 1 commit into
lance-format:mainfrom
u70b3:feat/python-mem-wal-delete

Conversation

@u70b3

@u70b3 u70b3 commented Jul 7, 2026

Copy link
Copy Markdown
Contributor

Summary

  • Expose MemWAL ShardWriter.delete(keys, *, schema=None) in the Python wrapper and PyO3 layer.
  • Reuse the existing PyArrow stream-to-RecordBatch conversion path for both put and delete.
  • Delegate primary-key validation and tombstone construction to Rust core, and add a Python end-to-end regression test that verifies a delete masks a base-table row.

Tests

  • cargo fmt --all
  • uv run make format
  • uv run pytest python/tests/test_mem_wal.py -q
  • uv run make lint (pyright reported 0 errors and 7 missing-type-stub warnings)
  • CARGO_BUILD_JOBS=8 cargo clippy --all --tests --benches -- -D warnings

@github-actions github-actions Bot added A-python Python bindings enhancement New feature or request labels Jul 7, 2026
@u70b3 u70b3 force-pushed the feat/python-mem-wal-delete branch from 084bce9 to 4f00405 Compare July 7, 2026 08:24
@hamersaw hamersaw self-requested a review July 8, 2026 15:12
@u70b3 u70b3 force-pushed the feat/python-mem-wal-delete branch from 4f00405 to 979ac02 Compare July 8, 2026 15:19

@hamersaw hamersaw left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great! Thanks for the PR.

@hamersaw hamersaw merged commit a1bb71b into lance-format:main Jul 8, 2026
14 checks passed
@u70b3 u70b3 deleted the feat/python-mem-wal-delete branch July 9, 2026 01:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

A-python Python bindings enhancement New feature or request

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants