✨ Add a function to create a download link for artifacts that can be used by agents when referencing the artifact in markdown/html - #3853
Open
sheetalgiri wants to merge 6 commits into
Open
Conversation
…instance is on laminhub
…instance is on laminhub
sheetalgiri
force-pushed
the
create_download_link_artifact
branch
from
August 12, 2026 15:50
77cce97 to
0535c13
Compare
…lamindb into create_download_link_artifact
Member
|
Nice idea! But rather than adding this here, I think we should extend
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Solution
artifact.create_download_link(). Closest thing that existed before wasln.Artifact.pathbut this does not create a proper link. The implementation closely follows the implementation in LaminHub for the same :https://github.com/laminlabs/laminhub/blob/6f213282d58707ecbd86ba896b4ebab78851c03b/frontend/src/lib/utils/utils.ts#L44-L69, except that the /storage/s3 endpoint can only be used if the instance is on LaminHub, so this is being checked for.Working example: https://lamin.ai/laminlabs/lamindata/artifact/pwSp3LRvGTVBoUzp0000?branch=verify_lineage_test