Skip to content

✨ Introduce the using argument in ln.save() - #3852

Open
falexwolf wants to merge 15 commits into
mainfrom
usingonsave
Open

✨ Introduce the using argument in ln.save()#3852
falexwolf wants to merge 15 commits into
mainfrom
usingonsave

Conversation

@falexwolf

@falexwolf falexwolf commented Aug 12, 2026

Copy link
Copy Markdown
Member

Sometimes one wants to save objects to non-default databases. The using argument is now officially supported in BaseSQLRecord.save() and also introduced in ln.save().

@falexwolf falexwolf changed the title ✨ Introduce using in ln.save() ✨ Introduce the using argument in ln.save() Aug 13, 2026
@codecov

codecov Bot commented Aug 13, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 93.33333% with 9 lines in your changes missing coverage. Please review.
✅ Project coverage is 88.33%. Comparing base (112244e) to head (350faa1).
⚠️ Report is 9 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/models/save.py 91.42% 3 Missing ⚠️
lamindb/models/schema.py 91.66% 3 Missing ⚠️
lamindb/models/_feature_manager.py 90.00% 2 Missing ⚠️
lamindb/models/sqlrecord.py 96.29% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3852      +/-   ##
==========================================
- Coverage   91.55%   88.33%   -3.22%     
==========================================
  Files          88       88              
  Lines       15747    15931     +184     
==========================================
- Hits        14417    14073     -344     
- Misses       1330     1858     +528     
Files with missing lines Coverage Δ
lamindb/curators/core.py 84.01% <100.00%> (+0.55%) ⬆️
lamindb/models/__init__.py 100.00% <100.00%> (ø)
lamindb/models/_from_values.py 95.02% <100.00%> (ø)
lamindb/models/artifact_set.py 94.44% <100.00%> (ø)
lamindb/models/feature.py 93.35% <100.00%> (ø)
lamindb/models/sqlrecord.py 92.26% <96.29%> (+0.19%) ⬆️
lamindb/models/_feature_manager.py 90.57% <90.00%> (+0.24%) ⬆️
lamindb/models/save.py 93.30% <91.42%> (-0.82%) ⬇️
lamindb/models/schema.py 93.75% <91.66%> (-0.16%) ⬇️

... and 10 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Aug 13, 2026

Copy link
Copy Markdown

Deployment URL: https://5f8e588b.lamindb.pages.dev

…sing using it searches for links in that database
@Raaghav-Pillai

Copy link
Copy Markdown
Collaborator

Need to add a similar fix that was for write for read in which when it is doing .using(LOAD).to_dataframe(include="features") it should use connected database as default

@Raaghav-Pillai

Copy link
Copy Markdown
Collaborator

bulk_set_features_in_records at line 2326 needs to handle multi-valued features

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants