Skip to content

♻️ Refactor handling of unset types in HasType - #3851

Merged
ishitajain9717 merged 8 commits into
mainfrom
making_deafult_to_auto
Aug 12, 2026
Merged

♻️ Refactor handling of unset types in HasType#3851
ishitajain9717 merged 8 commits into
mainfrom
making_deafult_to_auto

Conversation

@ishitajain9717

Copy link
Copy Markdown
Contributor

In this PR, we make a minor change to make "Auto" as default rather than "None", so as to deal with duplication issues separately

@codecov

codecov Bot commented Aug 12, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 86.97%. Comparing base (112244e) to head (5f68d87).
⚠️ Report is 7 commits behind head on main.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3851      +/-   ##
==========================================
- Coverage   91.55%   86.97%   -4.58%     
==========================================
  Files          88       88              
  Lines       15747    15838      +91     
==========================================
- Hits        14417    13775     -642     
- Misses       1330     2063     +733     
Files with missing lines Coverage Δ
lamindb/models/feature.py 93.35% <100.00%> (ø)
lamindb/models/record.py 94.51% <100.00%> (ø)
lamindb/models/schema.py 93.91% <100.00%> (ø)
lamindb/models/sqlrecord.py 92.11% <100.00%> (+0.04%) ⬆️
lamindb/models/ulabel.py 97.58% <100.00%> (ø)

... and 16 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

Copy link
Copy Markdown

Deployment URL: https://2c3e8594.lamindb.pages.dev

Comment thread testbranch_id.txt Outdated
Comment thread lamindb/models/sqlrecord.py Outdated
@falexwolf falexwolf changed the title Minor changes so as to fix project duplication issue ♻️ Refactor handling of unset types Aug 12, 2026
@falexwolf falexwolf changed the title ♻️ Refactor handling of unset types ♻️ Refactor handling of unset types in HasType Aug 12, 2026
@falexwolf

Copy link
Copy Markdown
Member

Awesome, @ishitajain9717! This is a great solution.

I only have very minor comments. Feel free to merge once they're addressed.

@falexwolf
falexwolf self-requested a review August 12, 2026 10:41
@ishitajain9717
ishitajain9717 merged commit e1f94ee into main Aug 12, 2026
21 of 22 checks passed
@ishitajain9717
ishitajain9717 deleted the making_deafult_to_auto branch August 12, 2026 13:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants