🐛 Fix the filtering for the existing records check - #3845
Open
ishitajain9717 wants to merge 2 commits into
Open
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #3845 +/- ##
==========================================
- Coverage 91.55% 86.99% -4.56%
==========================================
Files 88 88
Lines 15747 15772 +25
==========================================
- Hits 14417 13721 -696
- Misses 1330 2051 +721
🚀 New features to boost your workflow:
|
|
Deployment URL: https://2f1d926a.lamindb.pages.dev |
falexwolf
reviewed
Aug 6, 2026
| subset = record.__class__ | ||
| exact_match = subset.filter(**{name_field: kwargs[name_field]}).first() | ||
| # Fallback: if no match was found and no type= was passed, also search for | ||
| # is_type=True records that have a non-null parent type. Such records (e.g. a |
Member
There was a problem hiding this comment.
I don't understand why is_type=True is missed above. Can you explain?
falexwolf
reviewed
Aug 6, 2026
| exact_match = subset.filter(**{name_field: kwargs[name_field]}).first() | ||
| # Fallback: if no match was found and no type= was passed, also search for | ||
| # is_type=True records that have a non-null parent type. Such records (e.g. a | ||
| # Project subtype) are missed by the filter(type__isnull=True) above and would |
Member
There was a problem hiding this comment.
Are you 100% sure about this? I'm not seeing why it would be missed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Here, in this PR we are trying to fix the criteria for checking of existing projects to avoid deduplication.
Fixes: pfizer-collab/laminlabs#1139