Skip to content

🚸 Print a warning if overwrite_versions is true - #3792

Open
falexwolf wants to merge 1 commit into
mainfrom
warningartifact
Open

🚸 Print a warning if overwrite_versions is true#3792
falexwolf wants to merge 1 commit into
mainfrom
warningartifact

Conversation

@falexwolf

@falexwolf falexwolf commented Jul 7, 2026

Copy link
Copy Markdown
Member

It might be surprising in particular for new users to see that.

@falexwolf
falexwolf requested review from Koncopd and sheetalgiri July 7, 2026 14:23
@falexwolf

Copy link
Copy Markdown
Member Author

The annoying thing is if you ingest 100 folders and then you see this 100 times.

This is what Python's warning module can help avoid. But I'm also not sure whether we need to raise an official warning; this is just a logging message to the user IMO.

@falexwolf

Copy link
Copy Markdown
Member Author

We might actually have had this warning before and removed it for this this reason. 🤔

@codecov

codecov Bot commented Jul 7, 2026

Copy link
Copy Markdown

Codecov Report

❌ Patch coverage is 50.00000% with 1 line in your changes missing coverage. Please review.
✅ Project coverage is 86.91%. Comparing base (a756d90) to head (a4594b6).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
lamindb/models/artifact.py 50.00% 1 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #3792      +/-   ##
==========================================
- Coverage   91.55%   86.91%   -4.64%     
==========================================
  Files          88       88              
  Lines       15611    15642      +31     
==========================================
- Hits        14292    13596     -696     
- Misses       1319     2046     +727     
Files with missing lines Coverage Δ
lamindb/models/artifact.py 91.80% <50.00%> (-1.93%) ⬇️

... and 17 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@github-actions

github-actions Bot commented Jul 7, 2026

Copy link
Copy Markdown

Deployment URL: https://82c6786d.lamindb.pages.dev

@sheetalgiri

Copy link
Copy Markdown
Contributor

I only see the warning if I explicitly set the parameter which is good but for folders where it is true by default (probably this is set somewhere later in the code) the warning doesn't show up
Screenshot 2026-07-07 at 16 44 12

@falexwolf
falexwolf force-pushed the main branch 2 times, most recently from 0fc6700 to 4001ef8 Compare July 18, 2026 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants