Skip to content

fix(l1): apply RocksDB max_bytes_for_level_base on state CFs #7113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
NikhilSharmaWe wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −12
Open

fix(l1): apply RocksDB max_bytes_for_level_base on state CFs #7113

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
20 changes: 8 additions & 12 deletions crates/storage/backend/rocksdb.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -49,18 +49,9 @@ impl RocksDBBackend {

opts.set_max_background_jobs(8);

opts.set_level_zero_file_num_compaction_trigger(2);
opts.set_level_zero_slowdown_writes_trigger(10);
opts.set_level_zero_stop_writes_trigger(16);
opts.set_target_file_size_base(512 * 1024 * 1024); // 512MB
opts.set_max_bytes_for_level_base(2 * 1024 * 1024 * 1024); // 2GB L1
opts.set_max_bytes_for_level_multiplier(10.0);
opts.set_level_compaction_dynamic_level_bytes(true);

// Only DBOptions belong here. Column-family options must be set on each
// ColumnFamilyDescriptor — open_cf_descriptors ignores CF fields on `opts`.
opts.set_db_write_buffer_size(1024 * 1024 * 1024); // 1GB
opts.set_write_buffer_size(128 * 1024 * 1024); // 128MB
opts.set_max_write_buffer_number(4);
opts.set_min_write_buffer_number_to_merge(2);

opts.set_wal_recovery_mode(rocksdb::DBRecoveryMode::PointInTime);
opts.set_max_total_wal_size(2 * 1024 * 1024 * 1024); // 2GB
Expand All @@ -73,7 +64,6 @@ impl RocksDBBackend {
opts.set_enable_write_thread_adaptive_yield(true);
opts.set_compaction_readahead_size(4 * 1024 * 1024); // 4MB
opts.set_advise_random_on_open(false);
opts.set_compression_type(rocksdb::DBCompressionType::None);

let compressible_tables = [
BLOCK_NUMBERS,
Expand Down Expand Up @@ -187,6 +177,9 @@ impl RocksDBBackend {
cf_opts.set_max_write_buffer_number(6);
cf_opts.set_min_write_buffer_number_to_merge(2);
cf_opts.set_target_file_size_base(256 * 1024 * 1024); // 256MB
// Base level target ≈ expected L0 size under memory-pressure flushes
// (db_write_buffer_size often flushes before a full 512MB×2 merge).
cf_opts.set_max_bytes_for_level_base(2 * 1024 * 1024 * 1024); // 2GB
cf_opts.set_memtable_prefix_bloom_ratio(0.2); // Bloom filter

let mut block_opts = BlockBasedOptions::default();
Expand All @@ -200,6 +193,9 @@ impl RocksDBBackend {
cf_opts.set_max_write_buffer_number(6);
cf_opts.set_min_write_buffer_number_to_merge(2);
cf_opts.set_target_file_size_base(256 * 1024 * 1024); // 256MB
// Base level target ≈ expected L0 size under memory-pressure flushes
// (db_write_buffer_size often flushes before a full 512MB×2 merge).
cf_opts.set_max_bytes_for_level_base(2 * 1024 * 1024 * 1024); // 2GB
cf_opts.set_memtable_prefix_bloom_ratio(0.2); // Bloom filter

let mut block_opts = BlockBasedOptions::default();
Expand Down