Skip to content

chore(manager): enforce repositories/services layer deps in BUILD#12932

Draft
fregataa wants to merge 2 commits into
mainfrom
chore/manager-build-layer-dep-rules
Draft

chore(manager): enforce repositories/services layer deps in BUILD#12932
fregataa wants to merge 2 commits into
mainfrom
chore/manager-build-layer-dep-rules

Conversation

@fregataa

Copy link
Copy Markdown
Member

Summary

  • Extend the manager __dependencies_rules__ to cover the repositories/ and services/ layers, alongside the existing data/views/models rules.
  • repositories/** may depend on models/data/dto but not services or api; services/** must not depend on api.
  • Makes the documented layer order (api → services → repositories → models) enforced at build time via Pants visibility instead of by review.

Test plan

  • pants lint --changed-since=origin/main passes (visibility check succeeds)

Extend the manager __dependencies_rules__ to cover the repositories and
services layers, mirroring the existing data/views/models rules:

- repositories/** may depend on models/data/dto but not services or api
- services/** must not depend on api

This makes the documented layer order (api → services → repositories →
models) enforced at build time via Pants visibility instead of by review.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
@fregataa
fregataa requested a review from a team as a code owner July 17, 2026 04:14
Copilot AI review requested due to automatic review settings July 17, 2026 04:14

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has reached their quota limit.

@github-actions github-actions Bot added the size:S 10~30 LoC label Jul 17, 2026
@github-actions github-actions Bot added the comp:manager Related to Manager component label Jul 17, 2026
@fregataa
fregataa force-pushed the chore/manager-build-layer-dep-rules branch from 939b940 to c4f4582 Compare July 17, 2026 06:24
@fregataa
fregataa marked this pull request as draft July 17, 2026 07:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

comp:manager Related to Manager component size:S 10~30 LoC

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants